Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay: Flush based on buffer size #7657

Closed
bruno-garcia opened this issue Mar 29, 2023 · 2 comments · Fixed by #8315
Closed

Replay: Flush based on buffer size #7657

bruno-garcia opened this issue Mar 29, 2023 · 2 comments · Fixed by #8315
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement

Comments

@bruno-garcia
Copy link
Member

Problem Statement

The server won't accept replays larger than 10 MB

Solution Brainstorm

Make sure to flush after time interval or certain size. In case we have more than 10 MB we need to discard the event and emit client report.
@bruno-garcia bruno-garcia added Type: Improvement Package: replay Issues related to the Sentry Replay SDK labels Mar 29, 2023
@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@mydea mydea reopened this Apr 27, 2023
@mydea mydea mentioned this issue Jun 12, 2023
Merged
@mydea
Copy link
Member

mydea commented Jun 12, 2023

I wrote #8315 which stops replay when the event buffer exceeds 20MB. I think this is the safe approach here...?

mydea added a commit that referenced this issue Jun 19, 2023
@mydea
feat(replay): Stop replay when event buffer exceeds max. size (#8315)
34bb403 
When the buffer exceeds ~20MB, stop the replay.

Closes #7657
Closes getsentry/team-replay#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Stop replay when event buffer exceeds max. size getsentry/sentry-javascript
2 participants
@bruno-garcia @mydea