Make AWS layer work with ESM

[sl0thentr0py]

Problem Statement

make a new lambda function with

// index.mjs - doesn't work
export const handler = (event) => {
    // TODO implement
    const response = {
        statusCode: 200,
        body: JSON.stringify('Hello from Lambda!'),
    };
    

    throw new Error("test error");  
    return response;
};

Solution Brainstorm

need to make this work with esm

sentry-javascript/packages/serverless/src/awslambda.ts

Lines 120 to 128 in ff4b1a8

	function tryRequire<T>(taskRoot: string, subdir: string, mod: string): T {
	const lambdaStylePath = resolve(taskRoot, subdir, mod);
	if (existsSync(lambdaStylePath) || existsSync(`${lambdaStylePath}.js`)) {
	// Lambda-style path
	return require(lambdaStylePath);
	}
	// Node-style path
	return require(require.resolve(mod, { paths: [taskRoot, subdir] }));
	}

[stefandarius]

Hi! I am trying to instrument a lambda function written with ESM. Any updates on this improvement?

[floriangosse]

I think the best solution would be to ship an ESM version next to the CJS version. Otherwise we would have to modify the package.json and remove the module property so that Node.js, even when imported from a ESM, would load the CJS version.

[AbhiPrasad]

Fixed with 8.0.0-beta.4: https://github.com/getsentry/sentry-javascript/releases/tag/8.0.0-beta.4

sentry-javascript/packages/aws-serverless/src/integration/awslambda.ts

Lines 10 to 16 in b5ebdb5

	addOpenTelemetryInstrumentation(
	new AwsLambdaInstrumentation({
	requestHook(span) {
	span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.otel.aws-lambda');
	},
	}),
	);

[AbhiPrasad]

superceded by #12409