Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM clicks on inputs does not always have input as the source element #8141

Closed
billyvg opened this issue May 16, 2023 · 2 comments
Closed

DOM clicks on inputs does not always have input as the source element #8141

billyvg opened this issue May 16, 2023 · 2 comments
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@billyvg
Copy link
Member

billyvg commented May 16, 2023 •
edited
Loading

See this replay as an example... it happens with Sentry's settings forms.

https://sentry.sentry.io/replays/7e38e0da35934f0cb3b03a1550f8adee/?referrer=%2Fissues%2F%3AgroupId%2F&t=5&t_main=dom

This will interfere with our slow click detection.
@billyvg billyvg added Status: Backlog Package: replay Issues related to the Sentry Replay SDK labels May 16, 2023
@mydea
Copy link
Member

mydea commented Jun 12, 2023

I think we can close this for now, we should detect clicks on buttons correctly now hopefully? WDYT?

@bruno-garcia
Copy link
Member

Logic was changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@billyvg @bruno-garcia @mydea