Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export a Prisma middleware #8384

Closed
lforst opened this issue Jun 22, 2023 · 3 comments
Closed

Export a Prisma middleware #8384

lforst opened this issue Jun 22, 2023 · 3 comments

Comments

@lforst
Copy link
Member

lforst commented Jun 22, 2023

Having an integration to instrument Prisma is probably not the best idea as shown in #8383

It's probably a good idea to have a simple Prisma middleware we export that is "immune" to weird multi-instrumentation issues.

@Blitz2145
Copy link

FYI middleware is getting deprecated: https://www.prisma.io/docs/concepts/components/prisma-client/middleware, but still in favor of less magical instrumentation here, perhaps playing nicely with prisma's builtin tracing feature would be best.

@lforst
Copy link
Member Author

lforst commented Jul 24, 2023

@Blitz2145 Thanks for letting us know. The clientExtensions are actually kinda dope because they let us inspect the queries directly (Which should lead to way better instrumentation)!

@AbhiPrasad
Copy link
Member

So given we now have https://github.com/getsentry/sentry-javascript/blob/develop/packages/node/src/integrations/tracing/prisma.ts I'm going to close this, but we can re-visit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants