Replay: Gracefully degrade if sessionStorage isn't available

[bruno-garcia]

Reported by a customer that runs their app on several different embedded browsers such as email apps

For example, if an Android embedded browser has settings.setDomStorageEnabled(false), then sessionStorage isn’t available. Sentry checks for this with sessionStorage in window, but it’s possible for that to be true, but window.sessionStorage to be null, resulting in later errors. This would prevent functionality from behaving as normal.

We might need to gate access to sessionStorage and if we can't access this at other spots we need to find a way to gracefully degrade the SDK. If Replay cant' work, we should disable recording, but let the other functionalies of the SDK (e.g: error reporting) continue to function

[bruno-garcia]

Wow that was fast! Thanks Francesco!

[mydea]

Just noticed https://sentry.sentry.io/issues/4286420853/?project=1267915&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=6 this can still happen - we should probably try-catch this!

[charleskoehl]

It still happens in our next.js app when it is in an iframe

SecurityError
Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
mechanism
instrument
handled
true
function
setTimeout

../../node_modules/@sentry/replay/esm/index.js in hasSessionStorage at line 4394:48
System

  return new EventBufferArray();
}
/** If sessionStorage is available. */
function hasSessionStorage() {
  return 'sessionStorage' in WINDOW && !!WINDOW.sessionStorage;
}
/**
 * Removes the session from Session Storage and unsets session in replay instance
 */
../../node_modules/@sentry/replay/esm/index.js in session at line 4538:1
System

../../node_modules/@sentry/replay/esm/index.js in session at line 4556:1
System

../../node_modules/@sentry/replay/esm/index.js in ReplayContainer._loadAndCheckSession at line 7669:29

[shakiba]

I also have this issue when sentry is in a sandboxed iframe.

[mydea]

I opened a fix to fully solve this here: #8547 - should go out in the next version!

[shakiba]

Awesome, thank you @mydea !

[mydea]

This is out in 7.59.2 now!

[shakiba]

Great, thank you!
I use @sentry/vite-plugin, it depends on 7.53.1, it would be great if you could update the version there as well.

[mydea]

The vite plugin should use it's own Sentry versions for internal stuff only. Is this interfering with your app somehow?

[shakiba]

Sorry, my bad. I just recalled I'm using script tag to add sentry to the page.
It's all good, thanks for fixing the issue!