Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay networkDetailAllowUrls is hard to use when you just want to block a couple known url patterns #8435

Closed
ryan953 opened this issue Jun 29, 2023 · 5 comments
Closed

Replay networkDetailAllowUrls is hard to use when you just want to block a couple known url patterns #8435

ryan953 opened this issue Jun 29, 2023 · 5 comments
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@ryan953
Copy link
Member

ryan953 commented Jun 29, 2023

Example config:
https://github.com/getsentry/getsentry/pull/11002

          networkDetailAllowUrls: [
            // Disallow:
            // `/api/0/customers/*`
            // `/api/0/invoices/*`
            // `/api/0/projects/<org>/<proj>/replays/<id>/replay-segments/`
            // Allow: all others
            /\/api\/0\/(?!(projects|customers|invoices)\/).*/,
            /\/api\/0\/projects\/[^/]*\/[^/]*\/(?!(replays\/))/,
            /\/api\/0\/projects\/[^/]*\/[^/]*\/replays\/[^/]*\/?!(recording-segments\/)/,
          ],

this should be easier
@ryan953 ryan953 changed the title networkDetailAllowUrls is hard to use when you just want to block a couple known url patterns Replay networkDetailAllowUrls is hard to use when you just want to block a couple known url patterns Jun 29, 2023
@ryan953
Copy link
Member Author

ryan953 commented Jun 29, 2023

cc @billyvg @mydea

@mydea
Copy link
Member

mydea commented Jun 30, 2023

Yeah, maybe we should add networkDetailDenyUrls option or similar (naming is hard - xxxDenyUrls, xxxDisallowUrls, xxxExcludeUrls???)...?

@mydea mydea added Type: Feature Package: replay Issues related to the Sentry Replay SDK labels Jun 30, 2023
@ryan953
Copy link
Member Author

ryan953 commented Jun 30, 2023

xyzBlockUrls xyzIgnoreUrls all good options

@ziyad-elabid-nw ziyad-elabid-nw mentioned this issue Jun 30, 2023
Merged
@ziyad-elabid-nw
Copy link
Contributor

ziyad-elabid-nw commented Jun 30, 2023 •
edited
Loading

Hello, that's a good point, i gave it a name of networkDetailExcludeUrls, could you please check my PR and tell me what do you think about it !

@mydea
Copy link
Member

mydea commented Jul 17, 2023

We have networkDetailDenyUrls now 🎉

@mydea mydea closed this as completed Jul 17, 2023
@p-himik p-himik mentioned this issue Dec 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryan953 @mydea @ziyad-elabid-nw