Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate integration-level tracePropagationTargets options in favour of top-level option #8851

Closed
Lms24 opened this issue Aug 21, 2023 · 1 comment · Fixed by #8874
Closed
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented Aug 21, 2023

Problem Statement

Our plans around the location of the tracePropagationTargets option have shifted a little. While in #6230 we opted direct people to use the integration-level TPT option, with the introduction of tracing without performance, we decided to add TPTs to the top-level Sentry.init options.

Solution Brainstorm

This means:

  • Deprecate tracePropagationTargets in BrowserTracing
  • Un-deprecate top-level tracePropagationTargets in Node
  • Deprecate tracePropagationTargets in Http integration

We should do this soon to avoid more confusion!

Discovered this during hackweek (/getsentry/sentry-migr8#1).

@Lms24
Copy link
Member Author

Lms24 commented Aug 28, 2023

Small update here:
Seems like I mistook the permalink from #6230 to be the current state of TPT in the Http integration. There it's already deprecated correctly. So all that's left is the deprecation in BrowserTracing which is addressed in #8874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant