Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Replay networkResponseHeaders is not capturing headers with apollo client #8886

Closed
jsfeb26 opened this issue Aug 23, 2023 · 10 comments
Closed
Assignees
Labels

Comments

@jsfeb26
Copy link

jsfeb26 commented Aug 23, 2023

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

We're using "@sentry/react": "^7.61.0" and "@apollo/client": "^3.8.1". I bumped to this version of apollo client to deal with this #8345.

That fixed the undefined response body and I thought it would also fix the missing response header but I'm still not seeing the response header.

Session Replay Configuration:

  new Sentry.Replay({
    maskAllText: false,
    blockAllMedia: true,
    networkDetailAllowUrls: [config.api.HOST ?? ''],
    networkResponseHeaders: ['X-Request-Id'],
  })

Expected Result

There should be an additional response header x-request-id

Actual Result

CleanShot 2023-08-23 at 09 06 45@2x

I've confirmed the same request in the actual app has the X-Request-Id response header

Product Area

Replays

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link

getsantry bot commented Aug 23, 2023

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link

getsantry bot commented Aug 23, 2023

Routing to @getsentry/product-owners-replays for triage ⏲️

@billyvg billyvg transferred this issue from getsentry/sentry Aug 28, 2023
@billyvg
Copy link
Member

billyvg commented Aug 28, 2023

Moved this to our SDK repo as it is likely an SDK issue.

@mydea
Copy link
Member

mydea commented Sep 11, 2023

Is this still an issue? I think we had a UI bug regarding the headers that has been fixed in the meanwhile, could you check again @jsfeb26 ?

@mydea mydea self-assigned this Sep 11, 2023
@TerencedzLi
Copy link

Hello, we're noticing the same issue of missing headers with default browser fetch

@jsfeb26
Copy link
Author

jsfeb26 commented Sep 18, 2023

@mydea

I am still seeing the issue. Would it require an update of the @sentry/react package? I'm still using 7.61.0. I can bump that to the latest version for our next release to see if that fixes it

@billyvg
Copy link
Member

billyvg commented Sep 18, 2023

@jsfeb26 We have not released an SDK fix since 7.61.0, @mydea was referring to a Sentry web UI fix. We'll look into this

@mydea
Copy link
Member

mydea commented Sep 20, 2023

@jsfeb26 or @TerencedzLi : Do you use Sentry SaaS? If so, could you provide the link to a replay where you see the incorrect headers?

@getsantry
Copy link

getsantry bot commented Oct 20, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@csvan
Copy link

csvan commented Jan 11, 2024

Still seeing this issue using on-prem sentry, but it appears to be sporadic for whatever reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants