You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Redis integration should support the redis-py RedisCluster client.
Sentry already supports redis-py-cluster, but it is end of life and has been ported into the official redis-py package, which Sentry also supports. It just doesn't support RedisCluster in redis-py.
Solution Brainstorm
It looks like @md384 already has a PR up for this: #2394
I couldn't find a corresponding issue so wanted to make sure it gets triaged.
The text was updated successfully, but these errors were encountered:
…2394)
This change adds support for cluster clients from the redis sdk (as opposed to the rediscluster library).
This has also been tested in my own app which uses clusters (but not asyncio clusters).
FixesGH-2523
* feat(integrations): add support for cluster clients from redis sdk
* fix: review round 1
* fix: explicit `is not None` checks
* fix: explicit `is not None` checks, take 2
* fix: add try/except to _set_db_data
* fix: handle additional spans and breadcrumbs caused by rediscluster initialization
* fix: typing for redis integration
* fix: simplify assertions
* add `capture_internal_exceptions`
Co-authored-by: Matthieu Devlin <[email protected]>
* rerun CI
---------
Co-authored-by: Daniel Szoke <[email protected]>
Problem Statement
The Redis integration should support the redis-py RedisCluster client.
Sentry already supports redis-py-cluster, but it is end of life and has been ported into the official redis-py package, which Sentry also supports. It just doesn't support RedisCluster in redis-py.
Solution Brainstorm
It looks like @md384 already has a PR up for this: #2394
I couldn't find a corresponding issue so wanted to make sure it gets triaged.
The text was updated successfully, but these errors were encountered: