Boost patch

Author: alwx

.github/workflows/e2e-v2.yml

@@ -164,7 +164,7 @@ jobs:
     strategy:
       fail-fast: false # keeps matrix running if one fails
       matrix:
-        rn-version: ['0.69.12', '0.81.0']
+        rn-version: ['0.71.11', '0.81.0']
         rn-architecture: ['legacy', 'new']
         platform: ['android', 'ios']
         build-type: ['production']
@@ -176,7 +176,7 @@ jobs:
             xcode-version: '16.2'
             runs-on: macos-14
           - platform: ios
-            rn-version: '0.69.12'
+            rn-version: '0.71.11'
             xcode-version: '14.2'
             runs-on: macos-13
           - platform: android
@@ -185,14 +185,14 @@ jobs:
           # exclude JSC for new RN versions (keeping the matrix manageable)
           - rn-version: '0.81.0'
             engine: 'jsc'
-          # exclude all rn versions lower than 0.70.0 for new architecture
-          - rn-version: '0.69.12'
+          # exclude all rn versions lower than 0.80.0 for new architecture
+          - rn-version: '0.71.11'
             rn-architecture: 'new'
           # exlude old rn version for use frameworks builds (to minimalize the matrix)
-          - rn-version: '0.69.12'
+          - rn-version: '0.71.11'
             platform: 'ios'
             ios-use-frameworks: 'static'
-          - rn-version: '0.69.12'
+          - rn-version: '0.71.11'
             platform: 'ios'
             ios-use-frameworks: 'dynamic'
           # use frameworks is ios only feature
@@ -238,7 +238,7 @@ jobs:
 
       - uses: actions/setup-java@v5
         with:
-          java-version: ${{ matrix.rn-version == '0.69.12' && '11' || '17' }}
+          java-version: '17'
           distribution: 'adopt'
 
       - name: Gradle cache
@@ -258,15 +258,6 @@ jobs:
       - name: Setup Plain RN ${{ matrix.rn-version }} App
         run: ./dev-packages/e2e-tests/cli.mjs ${{ matrix.platform }} --create
 
-        # The old node has to be enabled after creating the test app
-        # to avoid issues with the old node version
-      - run: corepack disable
-      - uses: actions/setup-node@v6
-        if: ${{ matrix.rn-version == '0.69.12' }}
-        with:
-          package-manager-cache: false
-          node-version: 16
-
       - uses: ruby/setup-ruby@v1
         if: ${{ matrix.platform == 'ios' }}
         with:
@@ -304,7 +295,7 @@ jobs:
     strategy:
       fail-fast: false # keeps matrix running if one fails
       matrix:
-        rn-version: ['0.69.12', '0.81.0']
+        rn-version: ['0.71.11', '0.81.0']
         rn-architecture: ['legacy', 'new']
         platform: ['android', 'ios']
         build-type: ['production']
@@ -315,16 +306,16 @@ jobs:
             rn-version: '0.81.0'
             runs-on: macos-14
           - platform: ios
-            rn-version: '0.69.12'
+            rn-version: '0.71.11'
             runs-on: macos-14
           - platform: android
             runs-on: ubuntu-latest
         exclude:
-          # exclude all rn versions lower than 0.70.0 for new architecture
-          - rn-version: '0.69.12'
+          # exclude all rn versions lower than 0.80.0 for new architecture
+          - rn-version: '0.71.11'
             rn-architecture: 'new'
           # e2e test only the default combinations
-          - rn-version: '0.69.12'
+          - rn-version: '0.71.11'
             engine: 'hermes'
           - rn-version: '0.81.0'
             engine: 'jsc'

dev-packages/e2e-tests/cli.mjs

@@ -63,14 +63,14 @@ const appSourceRepo = 'https://github.com/react-native-community/rn-diff-purge.g
 const appRepoDir = `${e2eDir}/react-native-versions/${RNVersion}`;
 const appName = 'RnDiffApp';
 const appDir = `${appRepoDir}/${appName}`;
-const testAppName = `${appName}.${platform == 'ios' ? 'app' : 'apk'}`;
+const testAppName = `${appName}.${platform === 'ios' ? 'app' : 'apk'}`;
 const testApp = `${e2eDir}/${testAppName}`;
 const appId = platform === 'ios' ? 'org.reactjs.native.example.RnDiffApp' : 'com.rndiffapp';
 const sentryAuthToken = env.SENTRY_AUTH_TOKEN;
 
 function runCodegenIfNeeded(rnVersion, platform, appDir) {
   const versionNumber = parseFloat(rnVersion.replace(/[^\d.]/g, ''));
-  const shouldRunCodegen = platform === 'android' && versionNumber >= 0.79;
+  const shouldRunCodegen = platform === 'android' && versionNumber >= 0.80;
 
   if (shouldRunCodegen) {
     console.log(`Running codegen for React Native ${rnVersion}...`);
@@ -84,9 +84,26 @@ function runCodegenIfNeeded(rnVersion, platform, appDir) {
     } catch (error) {
       console.error('Codegen failed:', error.message);
     }
+  } else {
+    console.log(`Skipping codegen for React Native ${rnVersion}`);
   }
 }
 
+function patchBoostIfNeeded(rnVersion, patchScriptsDir) {
+  const versionNumber = parseFloat(rnVersion.replace(/[^\d.]/g, ''));
+  const shouldPatchBoost = platform === 'ios' && versionNumber <= 0.80;
+
+  if (!shouldPatchBoost) {
+    console.log(`Skipping boost patch for React Native ${rnVersion}`);
+    return;
+  }
+  execSync(`${patchScriptsDir}/rn.patch.boost.js --podspec node_modules/react-native/third-party-podspecs/boost.podspec`, {
+    stdio: 'inherit',
+    cwd: appDir,
+    env: env,
+  });
+}
+
 // Build and publish the SDK - we only need to do this once in CI.
 // Locally, we may want to get updates from the latest build so do it on every app build.
 if (actions.includes('create') || (env.CI === undefined && actions.includes('build'))) {
@@ -152,8 +169,11 @@ if (actions.includes('create')) {
     env: env,
   });
 
+  // Patch boost
+  patchBoostIfNeeded(RNVersion, patchScriptsDir);
+
   // Set up platform-specific app configuration
-  if (platform == 'ios') {
+  if (platform === 'ios') {
     execSync('ruby --version', { stdio: 'inherit', cwd: `${appDir}`, env: env });
 
     execSync(`${patchScriptsDir}/rn.patch.podfile.js --pod-file Podfile --engine ${RNEngine}`, {
@@ -174,7 +194,7 @@ if (actions.includes('create')) {
       `${patchScriptsDir}/rn.patch.xcode.js --project ios/${appName}.xcodeproj/project.pbxproj --rn-version ${RNVersion}`,
       { stdio: 'inherit', cwd: appDir, env: env },
     );
-  } else if (platform == 'android') {
+  } else if (platform === 'android') {
     execSync(
       `${patchScriptsDir}//rn.patch.gradle.properties.js --gradle-properties android/gradle.properties --engine ${RNEngine}`,
       { stdio: 'inherit', cwd: appDir, env: env },
@@ -200,7 +220,7 @@ if (actions.includes('build')) {
   console.log(`Building ${platform}: ${buildType}`);
   var appProduct;
 
-  if (platform == 'ios') {
+  if (platform === 'ios') {
     // Build iOS test app
     execSync(
       `set -o pipefail && xcodebuild \
@@ -216,7 +236,7 @@ if (actions.includes('build')) {
     );
 
     appProduct = `${appDir}/ios/DerivedData/Build/Products/${buildType}-iphonesimulator/${appName}.app`;
-  } else if (platform == 'android') {
+  } else if (platform === 'android') {
     runCodegenIfNeeded(RNVersion, platform, appDir);
 
     execSync(`./gradlew assemble${buildType} -PreactNativeArchitectures=x86 --no-daemon`, {
@@ -234,15 +254,15 @@ if (actions.includes('build')) {
 
 if (actions.includes('test')) {
   // Run e2e tests
-  if (platform == 'ios') {
+  if (platform === 'ios') {
     try {
       execSync('xcrun simctl list devices | grep -q "(Booted)"');
     } catch (error) {
       throw new Error('No simulator is currently booted. Please boot a simulator before running this script.');
     }
 
     execFileSync('xcrun', ['simctl', 'install', 'booted', testApp]);
-  } else if (platform == 'android') {
+  } else if (platform === 'android') {
     try {
       execSync('adb devices | grep -q "emulator"');
     } catch (error) {

dev-packages/e2e-tests/patch-scripts/rn.patch.boost.js

@@ -0,0 +1,28 @@
+#!/usr/bin/env node
+
+const fs = require('fs');
+const { argv } = require('process');
+
+const parseArgs = require('minimist');
+const { debug } = require('@sentry/core');
+debug.enable();
+
+const args = parseArgs(argv.slice(2));
+if (!args.podspec) {
+  throw new Error('Missing --podspec');
+}
+
+// The reason behind this patch is that the boost podspec is pointing to an archive with the wrong hashsum.
+// The official workaround is to patch the URL as described here:
+// https://github.com/facebook/react-native/issues/42180
+
+debug.log('Patching Boost podspec: ', args.podspec);
+
+let content = fs.readFileSync(args.podspec, 'utf8');
+content = content.replace(
+  "https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2",
+  "https://archives.boost.io/release/1.76.0/source/boost_1_76_0.tar.bz2"
+);
+fs.writeFileSync(args.podspec, content);
+
+debug.log('Patched Boost podspec successfully!');