Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for java, objective-c, cocoa pods code #2534

Open
krystofwoldrich opened this issue Oct 10, 2022 · 0 comments
Open

Add lint for java, objective-c, cocoa pods code #2534

krystofwoldrich opened this issue Oct 10, 2022 · 0 comments

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Oct 10, 2022

Description

Similar to kotlin lint in Dart.

https://github.com/getsentry/sentry-dart/blob/fe217baa64bf65dac702f8ef5acd8a267f02b46c/.github/workflows/flutter.yml#L191-L204

  pod-lint:
    runs-on: macos-latest
    defaults:
      run:
        working-directory: ./flutter
    steps:
      - uses: actions/checkout@v3
      # https://github.com/CocoaPods/CocoaPods/issues/5275#issuecomment-315461879
      - run: pod lib lint ios/sentry_flutter.podspec --configuration=Debug --skip-import-validation --allow-warnings

  swift-lint:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./flutter
    steps:
      - uses: actions/checkout@v3
      - uses: norio-nomura/action-swiftlint@9f4dcd7fd46b4e75d7935cf2f4df406d5cae3684 # [email protected]

  ktlint:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./flutter
    steps:
      - uses: actions/checkout@v3

      - name: ktlint
        uses: ScaCap/action-ktlint@f22fa77f33cbfaf0a1a332aae1f176c8712c8a3c # [email protected]
        with:
          github_token: ${{ secrets.github_token }}
          reporter: github-pr-review
          android: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants