Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowlist for navigation route params #3488

Open
philipphofmann opened this issue Dec 22, 2023 · 3 comments
Open

Allowlist for navigation route params #3488

philipphofmann opened this issue Dec 22, 2023 · 3 comments

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Dec 22, 2023

Description

With #3487 shipped in 5.12.2 the SDK stopped sending navigation route params for auto-generated transactions because they could contain PII or other sensitive data. Instead of dropping all parameters, we could define an allow list and/or guard sending params with sendDefaultPii. Anyways, even if sendDefaultPii is on, we must drop parameters such as username and password.

Related docs PR getsentry/sentry-docs#8767 and Relay PR to scrub PII from transaction data getsentry/relay#2899.

@liamjones
Copy link
Contributor

For us, it'd be nice if you could just turn the 'include all params' feature back on rather than having to maintain a specific allow list - we never put anything sensitive in our nav params and the extra context can be invaluable. I suppose if the allow list supports regexps/patterns so we could easily say 'include everything' it'd be fine... 🤔

@kahest
Copy link
Member

kahest commented Jan 12, 2024

@krystofwoldrich krystofwoldrich self-assigned this Jan 12, 2024
@krystofwoldrich
Copy link
Member

Browse JS context, thank you @Lms24

Default browser routing instrumentation does not include query params, but Vue routing integration does add them to the spans data bag.

httpClientIntegration adds a raw URL to the event request via httpContextIntegration

From my side, the most user-friendly way would be to add allowList without sendDefaultPii, with no default values.

@krystofwoldrich krystofwoldrich removed their assignment Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Backlog
Development

No branches or pull requests

4 participants