Upload debug symbols fails on iOS in monorepo.

[joarkosberg]

The script sentry-xcode-debug-files.sh does not enable overriding the WITH_ENVIRONMENT variable. So in a monorepo, it does not find the with environment script.
All other environment variables I have needed to change are configurable. So would be nice if this one was too.

Looked into creating PR, with looking it up as a environment variable, but unsure if that is the preferable way.

[krystofwoldrich]

Hi, thank you for the message,

we would be happy to review your PR, definitely preferred.

I think the fix could look like this, if WITH_ENVIRONMENT is defined use it otherwise they node resolution to locate the react-native package:

[ -z "$WITH_ENVIRONMENT" ] && REACT_NATIVE_PACKAGE_PATH=$("$LOCAL_NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json'))")
[ -z "$WITH_ENVIRONMENT" ] && WITH_ENVIRONMENT="${SENTRY_CLI_PACKAGE_PATH}/scripts/xcode/with-environment.sh"
if [ -f "$WITH_ENVIRONMENT" ]; then
    . "$WITH_ENVIRONMENT"
fi

[joarkosberg]

Hi, thank you for the message,

we would be happy to review your PR, definitely preferred.

I think the fix could look like this, if WITH_ENVIRONMENT is defined use it otherwise they node resolution to locate the react-native package:

[ -z "$WITH_ENVIRONMENT" ] && REACT_NATIVE_PACKAGE_PATH=$("$LOCAL_NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json'))")
[ -z "$WITH_ENVIRONMENT" ] && WITH_ENVIRONMENT="${SENTRY_CLI_PACKAGE_PATH}/scripts/xcode/with-environment.sh"
if [ -f "$WITH_ENVIRONMENT" ]; then
    . "$WITH_ENVIRONMENT"
fi

Tested a version of your suggestion locally and created a PR here #3496 😊

[krystofwoldrich]

Thank you, we will review the PR.