Ref: CI Check for Replay Stubs #5235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d1fd647+dirty | 413.02 ms | 459.72 ms | 46.70 ms |
| 170d5ea+dirty | 407.92 ms | 422.49 ms | 14.57 ms |
| 6479fd5+dirty | 412.95 ms | 434.02 ms | 21.07 ms |
| 1226664+dirty | 347.45 ms | 386.60 ms | 39.15 ms |
| 4604da9+dirty | 366.44 ms | 398.10 ms | 31.66 ms |
| 5ee3314+dirty | 415.80 ms | 426.14 ms | 10.34 ms |
| b3b5b0d | 399.82 ms | 419.20 ms | 19.38 ms |
| e2fa43d | 451.68 ms | 462.42 ms | 10.74 ms |
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
| 2adbd1e+dirty | 433.98 ms | 427.96 ms | -6.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d1fd647+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 170d5ea+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 6479fd5+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 1226664+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
| 4604da9+dirty | 17.75 MiB | 19.74 MiB | 2.00 MiB |
| 5ee3314+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| b3b5b0d | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| e2fa43d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 2adbd1e+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
Previous results on branch: lz/replay-stub-check
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93d725f+dirty | 376.02 ms | 371.70 ms | -4.32 ms |
| 1fc635a | 386.06 ms | 408.76 ms | 22.70 ms |
| 26b64bd+dirty | 385.24 ms | 370.50 ms | -14.74 ms |
| 0904b5b+dirty | 362.86 ms | 364.67 ms | 1.81 ms |
| 1dd4cb6+dirty | 386.85 ms | 401.14 ms | 14.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93d725f+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 1fc635a | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 26b64bd+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 0904b5b+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 1dd4cb6+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 955f2eb+dirty | 388.13 ms | 433.56 ms | 45.44 ms |
| 2104bb9+dirty | 313.00 ms | 309.76 ms | -3.24 ms |
| 69602ce+dirty | 375.37 ms | 405.28 ms | 29.91 ms |
| 11ded16+dirty | 309.23 ms | 310.55 ms | 1.33 ms |
| 7be1f99+dirty | 369.02 ms | 399.60 ms | 30.58 ms |
| 6fee48d+dirty | 370.23 ms | 427.86 ms | 57.63 ms |
| 3bd3f0d+dirty | 334.38 ms | 402.19 ms | 67.81 ms |
| 5526494+dirty | 380.79 ms | 432.70 ms | 51.91 ms |
| c94a927+dirty | 411.32 ms | 443.18 ms | 31.86 ms |
| 9f211e3+dirty | 371.00 ms | 432.51 ms | 61.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 955f2eb+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 2104bb9+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 69602ce+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 11ded16+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| 7be1f99+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 6fee48d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 3bd3f0d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 5526494+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c94a927+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 9f211e3+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
Previous results on branch: lz/replay-stub-check
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93d725f+dirty | 367.48 ms | 411.40 ms | 43.92 ms |
| 26b64bd+dirty | 356.63 ms | 413.25 ms | 56.62 ms |
| 0904b5b+dirty | 354.26 ms | 415.50 ms | 61.24 ms |
| 1dd4cb6+dirty | 538.17 ms | 562.26 ms | 24.09 ms |
| 1fc635a+dirty | 363.53 ms | 393.92 ms | 30.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93d725f+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 26b64bd+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 0904b5b+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 1dd4cb6+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 1fc635a+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d751a5d+dirty | 1215.57 ms | 1220.56 ms | 4.99 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 49ef936+dirty | 1228.42 ms | 1217.09 ms | -11.33 ms |
| 6a70a7e+dirty | 1225.82 ms | 1230.79 ms | 4.98 ms |
| 69602ce+dirty | 1235.65 ms | 1230.82 ms | -4.83 ms |
| 1e7a472+dirty | 1223.39 ms | 1232.12 ms | 8.73 ms |
| 5c16cdc+dirty | 1209.32 ms | 1210.67 ms | 1.35 ms |
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| 4604da9+dirty | 1232.59 ms | 1232.26 ms | -0.33 ms |
| 07808fb+dirty | 1233.31 ms | 1232.77 ms | -0.54 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d751a5d+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 49ef936+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 6a70a7e+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 69602ce+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 1e7a472+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 5c16cdc+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 4604da9+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| 07808fb+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
Previous results on branch: lz/replay-stub-check
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0904b5b+dirty | 1221.90 ms | 1210.30 ms | -11.60 ms |
| 93d725f+dirty | 1215.06 ms | 1214.96 ms | -0.10 ms |
| 1dd4cb6+dirty | 1210.90 ms | 1224.42 ms | 13.52 ms |
| 26b64bd+dirty | 1231.79 ms | 1236.35 ms | 4.56 ms |
| 1fc635a+dirty | 1219.59 ms | 1231.59 ms | 12.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0904b5b+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 93d725f+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| 1dd4cb6+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 26b64bd+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 1fc635a+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d751a5d+dirty | 1212.22 ms | 1217.94 ms | 5.71 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 49ef936+dirty | 1221.27 ms | 1221.60 ms | 0.34 ms |
| 6a70a7e+dirty | 1231.40 ms | 1239.49 ms | 8.09 ms |
| 69602ce+dirty | 1230.59 ms | 1230.84 ms | 0.24 ms |
| 1e7a472+dirty | 1237.44 ms | 1231.14 ms | -6.29 ms |
| 5c16cdc+dirty | 1235.67 ms | 1241.18 ms | 5.51 ms |
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| 4604da9+dirty | 1208.67 ms | 1208.12 ms | -0.54 ms |
| 07808fb+dirty | 1240.76 ms | 1251.00 ms | 10.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d751a5d+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 49ef936+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 6a70a7e+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 69602ce+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 1e7a472+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 5c16cdc+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 4604da9+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| 07808fb+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
Previous results on branch: lz/replay-stub-check
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0904b5b+dirty | 1231.65 ms | 1235.65 ms | 4.01 ms |
| 93d725f+dirty | 1217.04 ms | 1220.55 ms | 3.51 ms |
| 1dd4cb6+dirty | 1223.71 ms | 1216.79 ms | -6.92 ms |
| 26b64bd+dirty | 1228.94 ms | 1244.28 ms | 15.34 ms |
| 1fc635a+dirty | 1218.21 ms | 1229.39 ms | 11.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0904b5b+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 93d725f+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| 1dd4cb6+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 26b64bd+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 1fc635a+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
|
|
lucas-zimerman
changed the title
lucas-zimerman
force-pushed
the
lz/replay-stub-check
branch
from
1420427 to
942017f
Compare
lucas-zimerman
changed the title
lucas-zimerman
force-pushed
the
lz/replay-stub-check
branch
from
cb53090 to
ff82ed7
Compare
lucas-zimerman
commented
Oct 29, 2025
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
lucas-zimerman
commented
Oct 29, 2025
antonis
reviewed
Oct 29, 2025
antonis
approved these changes
Oct 29, 2025
…entry-react-native into lz/replay-stub-check
… into lz/replay-stub-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
refresh
📜 Description
replay stubs are binary files, and when changes happens we reviewers do not know what actually changed.
This PR aims to give alerts on what was changed, like if the content is identical and creation time was changed, or if actually files were changed.
💡 Motivation and Context
💚 How did you test it?
CI
reference screenshots for when the file had different code: #5235 (comment)
reference screenshot for when the files are equal but only the creation date has changed: #5235 (comment)
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps