Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try vernier for profiling #2124

Closed
sl0thentr0py opened this issue Oct 5, 2023 · 5 comments · Fixed by #2372
Closed

Try vernier for profiling #2124

sl0thentr0py opened this issue Oct 5, 2023 · 5 comments · Fixed by #2372

Comments

@sl0thentr0py
Copy link
Member

https://github.com/jhawthorn/vernier

does multithreaded stuff

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Nov 3, 2023

@sl0thentr0py, mind if I try and poke around?

I'm only getting started, so:

  1. I'd like to setup something to profile and see how that looks in action — perhaps a reproducible demo of Mastodon running with Sentry profiler plugged in.
  2. Once that's done, I'll spike on using Vernier. My initial idea is to allow it as an option on the config level — so that the user can initially switch between stackprof and vernier, based on their preference or whatever they have in the bundle, or the Ruby version, seems like Vernier will need 3.2, and not everyone is there yet.
  3. I'll check how those profiles look in the UI — then we can perhaps take the first look at the spike PR.

Does that sound like a reasonable approach?

@sl0thentr0py
Copy link
Member Author

@natikgadzhi sure! we always welcome contributions

You'll basically need to extract the profile samples from vernier and massage them into our format.
You can refer here or ask me if you don't understand something about our profile payload, it's a bit confusing if you've never worked with it.

@natikgadzhi
Copy link
Contributor

Still on it — got distracted by shiny things like Spotlight and Crons 🤦🏼

@sl0thentr0py
Copy link
Member Author

it's ok.. take your time we're happy to take contributions but you don't have to do everything at once :)

@solnic
Copy link
Collaborator

solnic commented Aug 14, 2024

@sl0thentr0py do we want to support both and make it configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants