Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip concurrent threaded test on jruby #2415

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

this is testing some really obscure threading logic and hangs often on jruby

#skip-changelog

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (23fe6f5) to head (58a0b81).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   98.68%   98.69%   +0.01%     
==========================================
  Files         210      210              
  Lines       13957    13958       +1     
==========================================
+ Hits        13773    13776       +3     
+ Misses        184      182       -2     
Components Coverage Δ
sentry-ruby 99.06% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 97.11% <ø> (+0.32%) ⬆️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
...-ruby/spec/sentry/breadcrumb/sentry_logger_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 0c875e4 into master Sep 23, 2024
140 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/skip-jruby-test branch September 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants