Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HandlerMessageBody to SentryException #861

Closed
wants to merge 7 commits into from
Closed

Add HandlerMessageBody to SentryException #861

wants to merge 7 commits into from

Conversation

y4roc
Copy link

@y4roc y4roc commented Jul 12, 2024

This PR should resolve #703.

Jean85
Jean85 requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a feasible approach: throwing an exception is a no-go, also you're giving for granted that the message is in JSON (which is not even the default for Messenger).

@y4roc
Copy link
Author

y4roc commented Jul 12, 2024 •
edited
Loading

getMessage() will always return an object. So normally, no exception will be thrown. I would add an option to deactivate the messageBody, because sometimes it will include secret dates.

In future it would be great to have a service, wich can hide some properties.

@y4roc y4roc requested a review from Jean85 July 12, 2024 11:35
@4rthem
Copy link

4rthem commented Sep 16, 2024

Hi, this PR had a better approach.

@cleptric cleptric closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Awaiting requested review from Jean85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add message id or content for exception thown in SF Messenger handlers
4 participants
@y4roc @4rthem @Jean85 @cleptric