Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode SymbolUpload BuildPhase run whether SentryCliOptions.UploadSymbols is true or not #1973

Open
nakwonchoi-5minlab opened this issue Jan 20, 2025 · 1 comment

Comments

@nakwonchoi-5minlab
Copy link

Environment

How do you use Sentry?
self-hosted

Which version of the SDK?
2.1.5

How did you install the package?
UPM https://github.com/getsentry/unity.git#2.1.5

Which version of Unity?
2022.3.51f1

Is this happening in Unity (editor) or on a player like Android, iOS, Windows?
iOS

Steps to Reproduce

  1. Setup 'Debug Symbols'
  2. turn off Upload Symbols

Expected Result

In Xcode Project, SymbolUpload does not exist

Actual Result

Image

Any logs or screenshots

if (cliOptions != null && cliOptions.IsValid(logger, EditorUserBuildSettings.development))
{
logger.LogInfo("Automatic symbol upload enabled. Adding script to build phase.");
SentryCli.CreateSentryProperties(pathToProject, cliOptions, options);
SentryCli.SetupSentryCli(pathToProject, RuntimePlatform.OSXEditor);
sentryXcodeProject.AddBuildPhaseSymbolUpload(cliOptions);
}

@bitsandfoxes
Copy link
Contributor

Thanks for raising this @nakwonchoi-5minlab! It looks like the cleanup for appending builds cleaning up the symbol upload is missing. We'll have to remedy this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants