From 7a47acab5b5fb6a1ee92299cd5a318cfd21b4e9a Mon Sep 17 00:00:00 2001 From: Michelle Fu Date: Thu, 16 Jan 2025 13:32:56 -0800 Subject: [PATCH] cleanup --- src/sentry/workflow_engine/migration_helpers/alert_rule.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sentry/workflow_engine/migration_helpers/alert_rule.py b/src/sentry/workflow_engine/migration_helpers/alert_rule.py index ee0c2bf1029612..5f186620d4cad0 100644 --- a/src/sentry/workflow_engine/migration_helpers/alert_rule.py +++ b/src/sentry/workflow_engine/migration_helpers/alert_rule.py @@ -390,7 +390,6 @@ def update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str, ] | None ): - # TODO: maybe pull this into a helper method? try: alert_rule_detector = AlertRuleDetector.objects.get(alert_rule=alert_rule) except AlertRuleDetector.DoesNotExist: @@ -461,8 +460,6 @@ def update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str, # reset detector status, as the rule was updated detector_state.update(active=False, state=DetectorPriorityLevel.OK) - # TODO: do we need to create an audit log entry here? - # do we need to return the detector's data conditions/DCG? return detector_state, detector