Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grouping] Buggy edge cases in filter_exceptions_for_exception_groups - no/empty exception 0 #73592

Open
lobsterkatie opened this issue Jul 1, 2024 · 0 comments

Comments

@lobsterkatie
Copy link
Member

lobsterkatie commented Jul 1, 2024

TL;DR: In our chained-exception strategy, we're not handling the case of one or more outer wrapper errors being gone very well.

Relates to this KeyError event, which is erroring out here because there is no entry 0 in exception_tree (which is a dict). Values are added to exception_tree a little higher up in the function, and they're based on mechanism.exception_id and mechanism.parent_id.

I went and checked out the issue that was being processed, and indeed, neither of the exceptions would put anything at 0:

image

Seems like we peeled off more than one outer/wrapper exception.

Not high priority, because it's only happened once that we know of, but something we might want to make more robust regardless.

UPDATE: The same project (but a different event, from a different SDK) caused a related error a few lines later. The JSON was equivalent to the above, except one of the parent_ids was 0 (though there was no actual exception 0 in the data). As a result, exception_tree[0] was an empty ExceptionTreeNode (from here), which then made the if block creating top_level_exceptions not run, which then made iterating through it a few lines later error out.

@lobsterkatie lobsterkatie changed the title [grouping] Buggy edge case in filter_exceptions_for_exception_groups - no exception 0 [grouping] Buggy edge cases in filter_exceptions_for_exception_groups - no/empty exception 0 Jul 1, 2024
@getsentry getsentry deleted a comment from sentry-io bot Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant