Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKs should send ip_address = {{auto}} by default and not guarded by sendDefaultPii #144

Open
2 of 4 tasks
marandaneto opened this issue Jul 17, 2023 · 2 comments
Open
2 of 4 tasks

Comments

@marandaneto
Copy link

marandaneto commented Jul 17, 2023

For disabling:

The project configuration has a toggle to disable storing the IP address.

Next step whenever needed:

Ideally, we'd need a new toggle on the project configuration to not store/derivate the location based on the IP Address.

Note

It's important that this is clearly explained in release notes, ideally with a link to the project settings to disable storing the IP address.

Tasks

  1. Platform: React-Native
  2. Platform: Cocoa Type: Enhancement
  3. Platform: Android Platform: Java
    markushi
  4. Breaking-change Platform: Dart
    denrase
@markushi
Copy link
Member

markushi commented Jul 20, 2023

I just checked sentry-java: How should the SDK behave when the IP address is set on an event and sendDefaultPii = false? Should the IP address be overridden with {{ auto }} or kept?

@marandaneto
Copy link
Author

@markushi user's value always has precedence, so {{ auto }} is only set if nothing is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Discussion
Development

No branches or pull requests

4 participants