Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Tag spans if they contribute to TTID / TTFD #155

Open
1 task done
markushi opened this issue Nov 8, 2023 · 2 comments
Open
1 task done

[EPIC] Tag spans if they contribute to TTID / TTFD #155

markushi opened this issue Nov 8, 2023 · 2 comments

Comments

@markushi
Copy link
Member

markushi commented Nov 8, 2023

Idea: Identify spans as TTID or TTFD contributing spans to narrow down which spans actively contribute to screen load times.

See Notion doc for details:
https://www.notion.so/sentry/Data-Requirements-b4f616bac8bc449096a765f915e0a209?p=9b5a0979a81645789db6877593729cf4&pm=s

Tasks

  1. Platform: Android
    markushi
@philipphofmann
Copy link
Member

The screen load transactions should already contain all the information to determine which spans contribute to TTID/TTFD. Do you think further changes are required, @markushi?

@markushi
Copy link
Member Author

markushi commented Nov 15, 2023

The screen load transactions should already contain all the information to determine which spans contribute to TTID/TTFD. Do you think further changes are required, @markushi?

In the advent of span-only I don't think we have a guarantee that all required spans will be sent over in a single txn. Thus it could make sense to calculate those two fields on the SDK side.

@shruthilayaj what do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants