Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Tag all spans during app start with start type info #174

Open
1 of 5 tasks
narsaynorath opened this issue Jan 31, 2024 · 0 comments
Open
1 of 5 tasks

[EPIC] Tag all spans during app start with start type info #174

narsaynorath opened this issue Jan 31, 2024 · 0 comments

Comments

@narsaynorath
Copy link
Member

narsaynorath commented Jan 31, 2024

For the mobile starfish app start module we want to allow users to be able to filter their spans by warm/cold start. We've decided to propagate a start type property in span data to facilitate this filter.

I propose adding a key called app_start_type to the span data field (docs on the data field) which can either have a value of cold or warm.

Tasks

  1. narsaynorath

The linked Relay PR will start filling in app_start_type by checking the measurements on a transaction to see if there is app_start_warm or app_start_cold timing. If the value is provided in the data field, then that will take precedence. This is so we can take advantage of the filtering before waiting for new SDK adoption, but will support extraction when moving towards span streaming.

It was suggested to use app context but it seems like Android may be missing the start type for certain transactions, e.g. see here. This seems like the most consistent method across Android and iOS at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant