Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enableTracing (and update docs accordingly) #84

Open
22 of 23 tasks
HazAT opened this issue May 1, 2024 · 7 comments
Open
22 of 23 tasks

Remove enableTracing (and update docs accordingly) #84

HazAT opened this issue May 1, 2024 · 7 comments

Comments

@HazAT
Copy link
Member

HazAT commented May 1, 2024

Currently, we offer multiple options to configure sampling for tracing:

  • tracesSampleRate
  • tracesSampler
  • enableTracing

But when to use which, is sometimes not obvious to our users. What makes this worse is that implications of some of them differ across SDKs, for example when it comes to Trace Propagation. In Python for example, propagation of trace headers works without any tracing config options in place being set. In Go, you need to at least set enableTracing to true in order to achieve the same result.

Goal is:

  • remove enableTracing in all SDKs
  • make tracesSampleRate the default, also in config snippets
  • explain how to get more out of sampling by using the tracesSampler function
  • mark enableTracing in all SDK docs as deprecated (config option page)

Deprecation

SDKs

Preview Give feedback
  1. Feature: Tracing Meta: Good First Issue
    lforst
  2. Platform: Dart
  3. Platform: Cocoa
  4. Platform: Android Platform: Java
    adinauer
@cleptric

This comment was marked as outdated.

@krystofwoldrich
Copy link
Member

RN will get this from JS.

@stephanie-anderson
Copy link
Collaborator

@bruno-garcia could you have a look at GDX SDKs, if all the points mentioned above are done? Stumbled across https://docs.sentry.io/platforms/dotnet/configuration/options/#enable-tracing which still exists - could you check if others are done?

@stephanie-anderson
Copy link
Collaborator

Also @szokeasaurusrex - could you go over the goals mentioned above and make sure they are done: enable_tracing is still mentioned in our docs: https://docs.sentry.io/platforms/python/configuration/options/#enable-tracing

@stephanie-anderson
Copy link
Collaborator

@sl0thentr0py Please make sure enable_tracing is gone from our docs: https://docs.sentry.io/platforms/ruby/configuration/options/#tracing-options

@stephanie-anderson
Copy link
Collaborator

@bitsandfoxes Could you have a look at Unity pls? https://docs.sentry.io/platforms/unity/configuration/options/#enable-tracing

@szokeasaurusrex szokeasaurusrex changed the title Remove enableTracing Remove enableTracing (and update docs accordingly) Feb 4, 2025
@timfish
Copy link

timfish commented Feb 4, 2025

The Electron SDK uses all the same types and core clients as the JavaScript SDKs so once the next major version is released, this options will no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

7 participants