-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enableTracing
(and update docs accordingly)
#84
Comments
This comment was marked as outdated.
This comment was marked as outdated.
enableTracing
RN will get this from JS. |
@bruno-garcia could you have a look at GDX SDKs, if all the points mentioned above are done? Stumbled across https://docs.sentry.io/platforms/dotnet/configuration/options/#enable-tracing which still exists - could you check if others are done? |
Also @szokeasaurusrex - could you go over the goals mentioned above and make sure they are done: |
@sl0thentr0py Please make sure |
@bitsandfoxes Could you have a look at Unity pls? https://docs.sentry.io/platforms/unity/configuration/options/#enable-tracing |
enableTracing
enableTracing
(and update docs accordingly)
The Electron SDK uses all the same types and core clients as the JavaScript SDKs so once the next major version is released, this options will no longer exist. |
Currently, we offer multiple options to configure sampling for tracing:
tracesSampleRate
tracesSampler
enableTracing
But when to use which, is sometimes not obvious to our users. What makes this worse is that implications of some of them differ across SDKs, for example when it comes to Trace Propagation. In Python for example, propagation of trace headers works without any tracing config options in place being set. In Go, you need to at least set
enableTracing
totrue
in order to achieve the same result.Goal is:
enableTracing
in all SDKstracesSampleRate
the default, also in config snippetstracesSampler
functionenableTracing
in all SDK docs as deprecated (config option page)Deprecation
SDKs
enableTracing
option sentry-javascript#12883enableTracing
option sentry-dart#2181enableTracing
option sentry-java#3566The text was updated successfully, but these errors were encountered: