cli/upgrade: Initial support for offline upgrades #47
Conversation
|
Is this ready for testing? |
joebonrichie
force-pushed
the
offline-updates
branch
2 times, most recently
from
3f3b00c to
901c7a1
Compare
|
Not listed in |
| # 4. System reboots and /system-update file is removed | ||
|
|
||
| # a bit of a hard coded safety hack here | ||
| if not os.path.exists('/usr/lib/systemd/system/system-update.target.wants/eopkg-offline-update.service'): |
There was a problem hiding this comment.
Shouldn't this be checking for the normal service file, not the symlink?
There was a problem hiding this comment.
Or rather, both. As both should always exist on the system and the system-update.target.wants is only executed when offline updates are detected by the /system-update symlink?
|
Sweet, got the offline update to work on my test laptop, very nice! It would also be nice to just get it to either A) display text showing eopkg output or B) show some sort of progress indicator and info that updates are in progress, please wait, etc. I think we should probably also log all output from the upgrade attempt somewhere on the disk so that if an offline upgrade fails, we can direct the user to a log file so we can analyze it. |
joebonrichie
force-pushed
the
offline-updates
branch
from
901c7a1 to
02887d4
Compare
|
Oh interesting, this did the updates before rebooting... 🤔 I pulled the latest commits and did it on my test laptop and I ran the updates, but it didn't reboot before doing the updates, it just appears to have dropped to a TTY, done the updates and then rebooted. Edit: Though it does show the text now which is good, which is why I now know that it does the updates before instead of after rebooting. |
|
Is this being abandoned? |
|
I think some of the branches have been renamed, so the PR has to target one of the new ones. I don't know if that can be done without opening a new PR. |
|
Ah, OK. Good to know it's not abandoned. It's an excellent feature to avoid issues when users do updates and do not reboot. |
https://www.freedesktop.org/software/systemd/man/latest/systemd.offline-updates.html
Resolves #45.