bugfix: correct helper setup docs for bash and zsh #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix instructions for zsh and bash so helper functions work Add note that people with custom zsh configs need to adapt instructions Add example of what zshrc should contain Fixes #576
EbonJaeger
reviewed
Dec 28, 2024
There was a problem hiding this comment.
The ZSH instructions still do not work. To get it to work before, I had an extra line in my .zshrc, I think given to me by @Staudey:
source "$HOME/.zshrc.d/solus-monorepo-helpers.zsh"It went after autoload -U $HOME/.zshrc.d/*. Whether or not that is the correct way to do things, I have no idea.
|
Yeah, I have two workarounds for this noted in my Either Or But as expected with the new instructions a simple added to . |
|
Thanks for the feedback. After some reading, it is indeed necessary to source the helper script in I also changed the setup command a bit to make it easier to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix instructions for zsh and bash so helper functions work Add note that people with custom zsh configs need to adapt instructions Add example of what zshrc should contain
Fixes #576
Testing
Verified solus helper commands can be run in a new shell session for both bash and zsh
For zsh, also created a test file in
~/.zshrc.dand verified it was able to be run without specifying the path