keyservice: update protobuf to a recent release, and make go code generation reproducible #1688
+226
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Linderud <[email protected]>
… Go plugin versions and install plugins locally. Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
protobuf
branch
from
88342a5
to
1c1fb89
Compare
Draft
hiddeco
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates PR #1576 by @Foxboron by adjusting the command line to work with the latest plugins and latest protoc (the command line from the PR somehow didn't work for newer protoc versions), and by fixing the versions of the gen-go and gen-go-grpc plugins and installing the required versions locally (similar as for other checks).
Closes #1576.