wrong abi for vulkan functions

[programmerjake]

in https://github.com/gfx-rs/portability/blob/master/libportability-icd/src/lib.rs#L15, the ICD functions should be extern "system" instead of extern "C" since, on 32-bit windows, they are stdcall. I'm not sure what to do about the hard float requirements when on armv7a android.
See https://github.com/KhronosGroup/Vulkan-Headers/blob/master/include/vulkan/vk_platform.h#L49

[kvark]

Thanks for filing the issue!
huh, I thought it works on Windows as it is now.
cc @msiglreith

[programmerjake]

it works because stdcall doesn't do anything on 64-bit windows.

[kvark]

Makes sense! Want to make a PR? :)

[programmerjake]

not at the moment. Also, all the functions that vulkan api users can directly call need to be extern "system" as well

[programmerjake]

ping

[kvark]

Would you want to help out with a PR?

…

On Apr 18, 2019, at 04:11, Jacob Lifshay ***@***.***> wrote: ping — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.