Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability and GZDoom #197

Closed
alexey-lysiuk opened this issue Jul 29, 2019 · 1 comment
Closed

Portability and GZDoom #197

alexey-lysiuk opened this issue Jul 29, 2019 · 1 comment

Comments

@alexey-lysiuk
Copy link

This is a continuation of discussion I started in #125 by mistake. Sorry about that.
Historically, ZDoom and now GZDoom as its successor use this forum for bug reporting and feature suggestions.
An attempt to use GitHub issues was not very productive for us.

I take a look at EXT_metal_surface as we are shipping with the latest MoltenVK anyway.
For testing with its older versions I can always restore code with MVK_macos_surface.

Regarding the issue with surface lost during present, I managed to track it to this line so far.
As it works on three major OSes with various graphics hardware, I just expected the same behavior with Portability.
Please note that Vulkan renderer in GZDoom is still quite new, so some corner cases can lack proper handling.

@alexey-lysiuk
Copy link
Author

Like you suggested, recreation of swapchain after receiving VK_ERROR_SURFACE_LOST_KHR works just fine.
GZDoom is now using EXT_metal_surface which works with Portability 0.7 and MoltenVK 1.0.36 without a problem.
Support to MVK_macos_surface still exists, although it is not used by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant