Fix FreeExternalTexture

andyleiserson · andyleiserson · commit 0e96cb80497d · 2025-10-22T16:57:39.000-07:00
diff --git a/player/src/lib.rs b/player/src/lib.rs
@@ -157,9 +157,11 @@ impl Player {
                 self.external_textures.insert(id, external_texture);
             }
             Action::FreeExternalTexture(id) => {
+                // Note: external texture remains in the HashMap. "Free" and "Destroy"
+                // mean the opposite from WebGPU.
                 let external_texture = self
                     .external_textures
-                    .remove(&id)
+                    .get(&id)
                     .expect("invalid external texture");
                 external_texture.destroy();
             }

Original file line number	Diff line number	Diff line change
`@@ -157,9 +157,11 @@ impl Player {`
`157`	`157`	`self.external_textures.insert(id, external_texture);`
`158`	`158`	`}`
`159`	`159`	`Action::FreeExternalTexture(id) => {`
	`160`	`+ // Note: external texture remains in the HashMap. "Free" and "Destroy"`
	`161`	`+ // mean the opposite from WebGPU.`
`160`	`162`	`let external_texture = self`
`161`	`163`	`.external_textures`
`162`		`- .remove(&id)`
	`164`	`+ .get(&id)`
`163`	`165`	`.expect("invalid external texture");`
`164`	`166`	`external_texture.destroy();`
`165`	`167`	`}`