feat: implement F16 support in shaders #5701

FL33TW00D · 2024-05-13T23:00:52Z

Connections

Hard dependency on WGSL: Add a skeleton for enable-extensions/enable …; that reports nice errors #6424.
Resolves WGSL: Support the enable directive #5476.
Resolves [meta] f16 support #4384.

Checklist for merge-ability

Additional context

F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types

naga/src/front/wgsl/error.rs

examples/src/shader_f16/shader.wgsl

FL33TW00D · 2024-05-15T21:20:11Z

I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it.

2 main blockers are:

Merging of the PR on half-rs.
hexf-parse improved implementation.

naga/src/proc/constant_evaluator.rs

naga/src/front/wgsl/parse/mod.rs

FL33TW00D · 2024-05-20T20:21:06Z

Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream.

naga/src/proc/constant_evaluator.rs

naga/src/front/wgsl/parse/lexer.rs

naga/src/front/wgsl/parse/ast.rs

naga/src/back/msl/writer.rs

naga/src/back/spv/writer.rs

teoxoy · 2024-06-13T17:49:13Z

One thing I'm concerned is that the polyfills we have in some of the backends might not support f16. It would be worth adding more tests covering the built-in functions and operations that support f16. Execution tests would be great as well, they live in tests/tests/shader.

raphamorim · 2025-01-06T17:36:06Z

You forgot to specify the branch in the cargo git dep!

You are indeed correct, thank you!

cwfitzgerald · 2025-01-13T18:56:09Z

Getting this over the line is on my list, will probably be next week.

ErichDonGubler · 2025-01-22T19:04:11Z

I've resolved conflicts with the latest examples/ changes (I think, spot check me @cwfitzgerald), and added a fixup! that tentatively consumes @raphamorim's half-2 crate.

cwfitzgerald · 2025-02-01T04:28:01Z

I have split the hex parsing task into a different work item to follow this. See #7046.

ErichDonGubler · 2025-02-04T18:52:01Z

Just realized that we didn't have the vec{2,3,4}h type aliases getting added to WGSL here. Pushed up 493e740 as a fixup! to remediate that.

cwfitzgerald · 2025-02-04T21:16:22Z

Restored ownership of the commit, sorry about that :)

raphamorim · 2025-02-05T23:39:52Z

man it's happening, let's go! ❤️

@cwfitzgerald @ErichDonGubler please lemme know if i can help somehow

examples/features/Cargo.toml

naga/Cargo.toml

naga/src/back/wgsl/writer.rs

cwfitzgerald · 2025-02-21T00:56:06Z

naga/src/valid/type.rs

+    pub(super) const fn check_width(
+        &self,
+        scalar: crate::Scalar,
+    ) -> Result<PushConstantCompatibility, WidthError> {
+        let mut push_constant_compatibility = Ok(());


This is the one change I wasn't sure about, but this solution does end up working fine.

cwfitzgerald · 2025-02-21T00:56:49Z

naga/tests/example_wgsl.rs


 /// Runs through all example shaders and ensures they are valid wgsl.
 #[test]
 pub fn parse_example_wgsl() {
-    let read_dir = match PathBuf::from(env!("CARGO_MANIFEST_DIR"))


This needs to be factored out.

Split out as #7191

naga/tests/in/f16.wgsl

cwfitzgerald · 2025-02-21T01:24:07Z

naga/tests/out/spv/atomicCompareExchange-int64.spvasm

@@ -1,17 +1,17 @@
 ; SPIR-V
 ; Version: 1.0
 ; Generator: rspirv
-; Bound: 125
+; Bound: 123


Why did this change?

Oh I remember why - the old As code ended up allocating an id that it never used. The new code does not have this property, so there's some small renumberings in the other spvasm files.

Co-authored-by: FL33TW00D <[email protected]> Co-authored-by: ErichDonGubler <[email protected]>

FL33TW00D mentioned this pull request May 14, 2024

feature: SHADER-F16 #5700

Closed

FL33TW00D changed the title ~~feature: Parse enable directives~~ feature: Parse enable directives & SHADER-F16 support May 14, 2024

This was referenced May 14, 2024

feature: Add f16 feature rust-fuzz/arbitrary#180

Closed

WGSL: Support the enable directive #5476

Closed

[meta] f16 support #4384

Open

FL33TW00D commented May 14, 2024

View reviewed changes

naga/src/front/wgsl/error.rs Outdated Show resolved Hide resolved

FL33TW00D commented May 14, 2024

View reviewed changes

examples/src/shader_f16/shader.wgsl Outdated Show resolved Hide resolved

FL33TW00D mentioned this pull request May 15, 2024

feature: Arbitrary starkat99/half-rs#111

Open

FL33TW00D marked this pull request as ready for review May 15, 2024 21:19

FL33TW00D requested a review from a team May 15, 2024 21:19

FL33TW00D requested a review from a team as a code owner May 15, 2024 21:19

FL33TW00D commented May 15, 2024

View reviewed changes

naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved

FL33TW00D commented May 15, 2024

View reviewed changes

naga/src/front/wgsl/parse/mod.rs Outdated Show resolved Hide resolved

FL33TW00D force-pushed the feature/enable branch from 8c5c498 to 04289ec Compare May 20, 2024 09:15

FL33TW00D mentioned this pull request May 28, 2024

WebGPU computer shader seems not working when using float16 type denoland/deno#23125

Open

FL33TW00D requested a review from ErichDonGubler May 29, 2024 09:09

FL33TW00D mentioned this pull request Jun 4, 2024

Implement f16 on wgpu huggingface/ratchet#41

Closed

teoxoy requested changes Jun 13, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

teoxoy self-assigned this Jun 13, 2024

FL33TW00D force-pushed the feature/enable branch 2 times, most recently from 9c6a9b3 to 9f33e0e Compare June 14, 2024 14:20

This comment was marked as outdated.

Sign in to view

ErichDonGubler added type: enhancement New feature or request backend: webgpu Issues with direct interface with WebGPU labels Jun 14, 2024

cwfitzgerald self-assigned this Jan 6, 2025

ErichDonGubler force-pushed the feature/enable branch from 808db24 to aac66f9 Compare January 6, 2025 21:51

This comment was marked as outdated.

Sign in to view

cwfitzgerald unassigned teoxoy Jan 8, 2025

ErichDonGubler force-pushed the feature/enable branch from aac66f9 to 64c94b8 Compare January 11, 2025 15:02

ErichDonGubler force-pushed the feature/enable branch from 64c94b8 to e68c86e Compare January 22, 2025 19:03

ErichDonGubler force-pushed the feature/enable branch from e68c86e to 16a41a2 Compare January 28, 2025 15:47

cwfitzgerald force-pushed the feature/enable branch 2 times, most recently from 8192315 to d4909a2 Compare February 1, 2025 04:27

cwfitzgerald force-pushed the feature/enable branch from d4909a2 to d57584d Compare February 1, 2025 04:38

cwfitzgerald force-pushed the feature/enable branch from 493e740 to 01bc1bd Compare February 4, 2025 19:43

cwfitzgerald force-pushed the feature/enable branch from 68ac734 to efb441d Compare February 6, 2025 00:18

This was referenced Feb 20, 2025

Fix wgpu-info's use of DXC #7184

Merged

[naga xtask] Improve Errors #7185

Merged

cwfitzgerald force-pushed the feature/enable branch 2 times, most recently from e6419c4 to 7b42714 Compare February 20, 2025 02:59

cwfitzgerald reviewed Feb 21, 2025

View reviewed changes

cwfitzgerald force-pushed the feature/enable branch from 7b42714 to 2343369 Compare February 21, 2025 04:49

cwfitzgerald mentioned this pull request Feb 21, 2025

Fix enumeration of wgpu example shaders in example_wgsl test #7191

Merged

cwfitzgerald force-pushed the feature/enable branch from 2343369 to a84765e Compare February 21, 2025 05:00

Implement F16 Support

9c06280

Co-authored-by: FL33TW00D <[email protected]> Co-authored-by: ErichDonGubler <[email protected]>

cwfitzgerald force-pushed the feature/enable branch from a84765e to 9c06280 Compare February 22, 2025 00:02

cwfitzgerald assigned jimblandy Feb 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement F16 support in shaders #5701

feat: implement F16 support in shaders #5701

FL33TW00D commented May 13, 2024 •

edited by cwfitzgerald

Loading

FL33TW00D commented May 15, 2024

FL33TW00D commented May 20, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

teoxoy commented Jun 13, 2024

This comment was marked as resolved.

This comment was marked as outdated.

raphamorim commented Jan 6, 2025

This comment was marked as outdated.

cwfitzgerald commented Jan 13, 2025

ErichDonGubler commented Jan 22, 2025

cwfitzgerald commented Feb 1, 2025

ErichDonGubler commented Feb 4, 2025

cwfitzgerald commented Feb 4, 2025

raphamorim commented Feb 5, 2025

cwfitzgerald Feb 21, 2025

cwfitzgerald Feb 21, 2025

cwfitzgerald Feb 21, 2025

cwfitzgerald Feb 21, 2025

cwfitzgerald Feb 21, 2025

feat: implement F16 support in shaders #5701

Are you sure you want to change the base?

feat: implement F16 support in shaders #5701

Conversation

FL33TW00D commented May 13, 2024 • edited by cwfitzgerald Loading

FL33TW00D commented May 15, 2024

FL33TW00D commented May 20, 2024 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

teoxoy commented Jun 13, 2024

This comment was marked as resolved.

This comment was marked as outdated.

raphamorim commented Jan 6, 2025

This comment was marked as outdated.

cwfitzgerald commented Jan 13, 2025

ErichDonGubler commented Jan 22, 2025

cwfitzgerald commented Feb 1, 2025

ErichDonGubler commented Feb 4, 2025

cwfitzgerald commented Feb 4, 2025

raphamorim commented Feb 5, 2025

cwfitzgerald Feb 21, 2025

Choose a reason for hiding this comment

cwfitzgerald Feb 21, 2025

Choose a reason for hiding this comment

cwfitzgerald Feb 21, 2025

Choose a reason for hiding this comment

cwfitzgerald Feb 21, 2025

Choose a reason for hiding this comment

cwfitzgerald Feb 21, 2025

Choose a reason for hiding this comment

FL33TW00D commented May 13, 2024 •

edited by cwfitzgerald

Loading

FL33TW00D commented May 20, 2024 •

edited

Loading