ggml : disable tests involving i-matrix quantization

ggerganov · Dec 17, 2024 · 8cc7145 · 8cc7145
1 parent b0597b1
commit 8cc7145
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/ggml/src/ggml-cpu/ggml-cpu.c b/ggml/src/ggml-cpu/ggml-cpu.c
@@ -2968,12 +2968,8 @@ static void ggml_compute_forward_dup_f16(
                         id += ne00 * (ne01 - ir1);
                     }
                 }
-            } else if (ggml_get_type_traits_cpu(dst->type)->from_float || ggml_get_type_traits(dst->type)->from_float_ref) {
-                ggml_from_float_t quantize_row_q = ggml_get_type_traits_cpu(dst->type)->from_float;
-                if (!quantize_row_q) {
-                    quantize_row_q = ggml_get_type_traits(dst->type)->from_float_ref;
-                }
-
+            } else if (ggml_get_type_traits_cpu(dst->type)->from_float) {
+                ggml_from_float_t const quantize_row_q = ggml_get_type_traits_cpu(dst->type)->from_float;
                 float * src0_f32 = (float *) params->wdata + (ne00 + CACHE_LINE_SIZE_F32) * ith;
 
                 size_t id = 0;
@@ -3569,11 +3565,8 @@ static void ggml_compute_forward_dup_f32(
                         id += rs * (ne01 - ir1);
                     }
                 }
-            } else if (ggml_get_type_traits_cpu(dst->type)->from_float || ggml_get_type_traits(dst->type)->from_float_ref) {
-                ggml_from_float_t quantize_row_q = ggml_get_type_traits_cpu(dst->type)->from_float;
-                if (!quantize_row_q) {
-                    quantize_row_q = ggml_get_type_traits(dst->type)->from_float_ref;
-                }
+            } else if (ggml_get_type_traits_cpu(dst->type)->from_float) {
+                ggml_from_float_t const quantize_row_q = ggml_get_type_traits_cpu(dst->type)->from_float;
 
                 size_t id = 0;
                 size_t rs = nb0 * (ne00 / ggml_blck_size(dst->type));

diff --git a/tests/test-backend-ops.cpp b/tests/test-backend-ops.cpp
@@ -3549,9 +3549,9 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval() {
 
     for (ggml_type type_src : {GGML_TYPE_F16, GGML_TYPE_F32}) {
         for (ggml_type type_dst : all_types) {
-            //if (type_dst == GGML_TYPE_IQ2_S || type_dst == GGML_TYPE_IQ3_XXS || type_dst == GGML_TYPE_IQ3_S) {
-            //    continue;
-            //}
+            if (type_dst == GGML_TYPE_IQ2_S || type_dst == GGML_TYPE_IQ3_XXS || type_dst == GGML_TYPE_IQ3_S) {
+                continue;
+            }
             test_cases.emplace_back(new test_cpy(type_src, type_dst, {256, 4, 4, 4}));
             test_cases.emplace_back(new test_cpy(type_src, type_dst, {256, 2, 3, 4}, {0, 2, 1, 3})); // cpy by rows
         }