fix: ggml: fix vulkan-shaders-gen build

[sparkleholic]

The vulkan-shaders-gen target was not being built correctly in case of cross-compilation.
Other outputs need to be built for the cross compile target, but vulkan-shaders-gen needs to be built for the host.

• I have read the contributing guidelines
• Self-reported review complexity:
  • Low
  • Medium
  • High

[sparkleholic]

@jeffbolznv , @0cc4m
This fix is ​​needed for cross-compilation.
vulkan-shaders-gen is needed at build time, so arch should be the same as host pc, but other binaries (libggml, libllama, etc.) are needed at runtime.
Therefore, CMAKE compilation variables that apply when building the llama.cpp project should not apply when building vulkan-shaders-gen in case of cross-compilation.

[0cc4m]

@sparkleholic @jeffbolznv I understand, I'm sorry that a few PRs are getting delayed because of me. I'm currently ill, but getting better and I should be able to catch up with all of them later this week.

Maybe you can resolve the merge conflict already?

[jeffbolznv]

No rush, get well!

I'm not an expert at cmake or cross compilation, so I don't think I should review the change.

[sparkleholic]

@0cc4m
master rebased to resolve conflicts.
I didn't mean to rush you. I sincerely hope you feel better soon. :)

[0cc4m]

I can confirm this still works as usual on my system, but I'm also not a CMake expert. Maybe @bandoti can take a look?

[bandoti]

I am happy to take a look. The one thing that comes to mind here after initial look through is being able to customize the compiler in this case. In particular, gcc and g++ are hardcoded.

It would be worthwhile to add a default toolchain file for the build and allow one to customize by passing -DGGML_SHADERS_GEN_CROSS_TOOLCHAIN=... (or similar)

This would allow one to use a desire toolchain—maybe clang, etc.

And a lot of those switches passed to ExternalProject_Add() can of course be moved to the toolchain file instead.

[sparkleholic]

@bandoti
Thank you for the valuable feedback.

I have updated the code to handle the GGML_SHADERS_GEN_TOOLCHAIN variable. When this variable is provided, the specified file is used. If it is not set, the code generates a temporary host toolchain file by detecting the host environment's compiler.

Please review the updated code once again.

[0cc4m]

@bandoti Can you take another look?

[bandoti]

@sparkleholic Sorry for the delay! I had these review comments in but forgot to submit them. 🤦‍♂️

[bandoti]

@sparkleholic Just following up on this change. If you need further assistance please let me know I am happy to help.

[sparkleholic]

@bandoti < Sorry for the late reply.
Thank you for the comments. I'll follow up this soon.

[sparkleholic]

Rebased branch to latest master.

[bandoti]

@sparkleholic No worries on the delay! Your contribution is greatly appreciated :)

It appears as though the test failure is unrelated to this. I'm wondering if merging the latest and rerunning the tests will clear the status. I have only one minor question in the review.

[bandoti]

Is the intention here to be the variable value or the name?

if (CMAKE_RUNTIME_OUTPUT_DIRECTORY)