New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving random initialization #9

Open

ghamerly opened this issue May 30, 2018 · 0 comments

Labels

Owner

ghamerly commented May 30, 2018

Right now the code for random initialization in https://github.com/ghamerly/fast-kmeans/blob/84a0e151e1006e510a6ec95d6606404ee54127e9/src/general_functions.cpp uses rand(), which is initialized by srand() here: https://github.com/ghamerly/fast-kmeans/blob/84a0e151e1006e510a6ec95d6606404ee54127e9/src/driver-experiment.cpp

We should move away from rand() and srand() towards C++ <random> classes (http://www.cplusplus.com/reference/random/). Further, in https://github.com/ghamerly/fast-kmeans/blob/84a0e151e1006e510a6ec95d6606404ee54127e9/src/driver-standalone.cpp there should be an option to seed the generator via command line parameter.

The text was updated successfully, but these errors were encountered:

ghamerly added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment