There's no "size_limit" implementation for GTK

[gtjoseph]

Without a "size_limit" implementation for GTK, if gtk-adwaita is enabled (the default), you can't size a window below about 482x322 pixels because it's left to gtk to decide what the minimum is. That's an issue.

If gtk-adwaita is disabled, you can actually size the window down to 0 lines and if gtk-titlebar is also disabled, you can also size it down to 0 columns. I'm not sure if this is an issue or not :)

Either way, I'l be submitting a PR to implement size_limit by calling gtk_widget_set_size_request(). There's still some minimum that adwaita imposes (about 357x248) but at least you can get reasonably close to the published minimums.

[rhodes-b]

Can you share more information there are many many people who use ghostty with adwaita enabled and can go much much smaller than 482x322 pixels (me being one of them)

[rhodes-b]

https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md#quick-guide

please read the contributing guide for the future, as random PRs are generally not accepted with no prior disucssion

[gtjoseph]

please read the contributing guide for the future, as random PRs are generally not accepted with no prior disucssion

@rhodes-b I'm a bit confused by your comment. I haven't submitted a PR for this yet let alone a random one and this IS the discussion. Is something else needed?

[rhodes-b]

Either way, I'l be submitting a PR

This very clearly states you were going to send a PR anyways

[gtjoseph]

Sorry. I should have been clearer. "either way" related to the two scenarios: with "gtk-adwaita" enabled (which I thought was an issue) and with "gtk-adwaita" disabled (which I thought may or may not be an issue). It didn't mean I was just going to toss up a PR without an OK from @mitchellh.

[mitchellh]

I'd be fine seeing a PR for this.

[pluiedev]

Fixed in #4840