Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe paste confirmation should not reveal contents in UI by default in secure input mode #4947

Open
mitchellh opened this issue Jan 11, 2025 · 0 comments
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK)

Comments

@mitchellh
Copy link
Contributor

Discussed in #4873

Originally posted by cryptocode January 9, 2025
In the image below (where I've cut off the password) I pasted a password with special characters for an ssh session, while in secure input "padlock mode"

The macOS secure input and padlock is a great feature that doesn't echo the password, so it's a bit of a bummer that the paste warning shows the password in clear text.

I feel like the warning should be suppressed, or at least not show the pasted value when in padlock mode.

image

Solution

We should send information along with the paste confirmation request of whether the paste contents are considered sensitive or part of secure input. If so, our UIs should hide the contents by default.

@mitchellh mitchellh added the gui GUI or app issue regardless of platform (i.e. Swift, GTK) label Jan 11, 2025
@mitchellh mitchellh changed the title Unsafe paste should not reveal contents in UI by default in secure input mode Unsafe paste confirmation should not reveal contents in UI by default in secure input mode Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK)
Projects
None yet
Development

No branches or pull requests

1 participant