-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Pypy build failing #2325
Comments
It must be noted that this is not a first, since we already have workarounds for missing psutil/psutil/_psutil_common.c Lines 23 to 68 in 902fada
We should add another workaround for |
The whole python C-API is an additional layer tacked on top of PyPy, which is implemented in Python and does not expose a C-API. There are hundreds (thousands?) of functions PyPy has implemented: ones needed for the scientific python stack, for Cython, and in CPython's own test suite (which passes on PyPy). But some are still missing. |
To be fair, running tests for PYPY on windows show some failures which seem to indicate bugs in how PYPY implements some C python APIs. |
Sorry, I didn't mean to suggest that PyPy does not have bugs. The opposite: there are definitely bugs and missing API functions. If possible, I would like to fix them. Please let me know. This package is one of the most popular and installed very often, so it is in a good place to let the PyPy devs know where we have problems. |
Sure. I don't have a laptop with with at the moment (I'm on vacation), but when I'm back I'll try to provide a report. If you want to start getting a glimpse, you can just run psutil test suite with PYPY on Windows. Last time I did that (some weeks ago, when I closed this issue) I bumped into some weird failures which seemed related to cPython APIs. E.g. I remember a |
I implemented the known missing PyErr interfaces, they will be in the next release of PyPy and will be available tomorrow on the nightly builds. |
psutil 5.9.7 which fixes this ticket was released. |
Summary
OS: GitHub runner
windows-latest
Architecture: 64-bit
Psutil version: built from
psutil-5.9.6.tar.gz
Python version:
Type: installation
Description
Currently trying to install psutil (as a required dependency) on GitHub's Windows runners. Unfortunately, it fails with the following error:
It would appear the error might be a result from using CPython-specific symbols.
Full log (link)
The text was updated successfully, but these errors were encountered: