Error in Argument Usage in filter_results_masking.py and filter_results_noise.py

[OrBerebi]

GitHub Issue: Error in Argument Usage in filter_results_masking.py and filter_results_noise.py

There is an error in the argument usage within both filter_results_masking.py and filter_results_noise.py. Specifically, this occurs in the lines where ambient_utils.dataset_utils.ImageFolderDataset is used. For example:

masks_dataset_obj = ambient_utils.dataset_utils.ImageFolderDataset(
    path=input_dir, 
    use_labels=False, 
    xflip=False,
    cache=cache, 
    corruption_probability=0.0, 
    delta_probability=0.0, 
    resolution=1024, 
    must_contain="mask", 
    must_not_contain="masked"
)

The arguments corruption_probability and delta_probability are not defined in ambient_utils/dataset_utils.py, resulting in the following error:

TypeError: __init__() got an unexpected keyword argument 'corruption_probability'

Quick Fix

A temporary fix was to remove both corruption_probability and delta_probability from the ImageFolderDataset calls and rely on the default values, which seem to work as intended.

Assumptions

It seems these arguments might actually refer to:

• corruption_probability_per_image
• corruption_probability_per_pixel
• delta_probability_per_pixel

However, I'll leave it up to the maintainers to decide the correct fix and whether these parameters need to be explicitly set or removed altogether.