Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating Clusters using an http proxy in cluster-cloud-director #1421

Closed
1 task
Tracked by #1424
cornelius-keller opened this issue Sep 2, 2022 · 8 comments
Closed
1 task
Tracked by #1424
Assignees

Comments

@cornelius-keller
Copy link
Contributor

cornelius-keller commented Sep 2, 2022

Support creating clusters using HTTP_PROXY in cluster-cloud-director.
Please make sure that we are using the same interface (helm variables) as team hydra. See giantswarm/cluster-aws#105

Tasks

  • Make sure that app platform still supports running behind a proxy so that we can get things bootstrapped.
@cornelius-keller cornelius-keller changed the title Support creating Workload Clusters cluster-cloud-director Support creating Clusters using an http proxy in cluster-cloud-director Sep 6, 2022
@cornelius-keller
Copy link
Contributor Author

Might already be done, needs to be verified @vxav

@vxav
Copy link

vxav commented Sep 19, 2022

We already have values used for nodes. Maybe we can reuse them for the rest.

https://github.com/giantswarm/cluster-cloud-director/blob/main/helm/cluster-cloud-director/values.yaml#L46-L49

@cornelius-keller cornelius-keller transferred this issue from another repository Sep 21, 2022
@cornelius-keller cornelius-keller transferred this issue from another repository Sep 21, 2022
@vxav
Copy link

vxav commented Sep 28, 2022

PR to align proxy values with CAPA => giantswarm/cluster-cloud-director#30
No change in functionality, we still use the native capvcd integration.
This only set environment variables on the nodes, not the workloads.

I suppose we just need to test this now. @glitchcrab we can have a look at your proxy and deploy a test cluster using it in the values?

@vxav
Copy link

vxav commented Oct 4, 2022

The HTTPS Proxy env variable is configured for containerd on the nodes and can pull images fine.
However it doesn't pupolate the HTTP env variable because of a typo. The maintainers are fixing it.

Will require to update controller+cluster chart to stay current.

@vxav
Copy link

vxav commented Oct 5, 2022

Closing this as it is done from a cluster chart perspective.

@vxav vxav closed this as completed Oct 5, 2022
@vxav vxav reopened this Oct 25, 2022
@vxav
Copy link

vxav commented Oct 25, 2022

After discussions, we want to use kubeadmconfigspec to make it consistent across provider and not use the CAPVCD built-in implementation with cloud-init.

@gawertm
Copy link

gawertm commented Nov 22, 2022

@vxav I think this story is already implemented? current proxy implementation by @bavarianbidi was tested on CAPVCD

@bavarianbidi
Copy link

The current implementation in cluster-cloud-director based on this PR in cluster-api-provider-cloud-director make it possible to create a cluster behind a proxy.

in upstream issue #299 we track the current process of our forked changes (as in one of the recent meetings with CAPVCD-maintainers we decided with them that the current build-in solution isn't very flexible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants