Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for k8s-dns-node-cache-app app #2305

Closed
4 tasks
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 4 comments
Closed
4 tasks
Tracked by #2066

Implement best practices for k8s-dns-node-cache-app app #2305

LolloneS opened this issue Apr 5, 2023 · 4 comments
Labels
team/cabbage Team Cabbage

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@JosephSalisbury
Copy link
Contributor

and @T-Kukawka also here hihihi <3

@mcharriere
Copy link

This app is actually own by Cabbage.

About the requirement, none of the points make sense. The app runs a daemonset; so no scaling, PDB or HA.
It has an emptyDir; which is needed.

If it's ok with you; let's close it.

@T-Kukawka T-Kukawka added team/cabbage Team Cabbage and removed team/phoenix Team Phoenix labels Oct 2, 2024
@T-Kukawka
Copy link
Contributor

moved to cabbage ✔️

@weatherhog
Copy link

fine for me to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/cabbage Team Cabbage
Projects
None yet
Development

No branches or pull requests

5 participants