Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aditional checks for node roll checking during upgrade tests #3451

Closed
yulianedyalkova opened this issue May 21, 2024 · 1 comment
Closed
Assignees
Labels
team/turtles Team Turtles

Comments

@yulianedyalkova
Copy link

In cluster-test-suites related to the test added in this PR . We could add some checks to see what changed so we can just skip the rolling update test. An example where it can be skipped is app version changes.

Slack thread: https://gigantic.slack.com/archives/C04KA9DBMB2/p1715853467155939?thread_ts=1715765100.692829&cid=C04KA9DBMB2

@weseven
Copy link

weseven commented Aug 6, 2024

Merged giantswarm/cluster-test-suites#422 to skip the test if the generation of the controlplane resource did not change after applying the new version.
This should cover all cases where there isn't an effective change on the control plane config that the capi controllers need to reconcile, and thus skip the rolling update test when node will not be rolled.

@weseven weseven closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/turtles Team Turtles
Projects
Archived in project
Development

No branches or pull requests

2 participants