Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-vpc-operator broken after AWSCluster CRD upgrade (subnets[*].resourceID?) #3577

Closed
AndiDog opened this issue Jul 15, 2024 · 0 comments · Fixed by giantswarm/aws-vpc-operator#141
Assignees
Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service kind/bug phoenix-size/s provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix topic/capi

Comments

@AndiDog
Copy link

AndiDog commented Jul 15, 2024

Bug description

CAPA private cluster E2E tests fail because aws-vpc-operator throws an error when cleaning up subnets (chat).

AWSCluster.infrastructure.cluster.x-k8s.io "t-b0r9t061akd1lzbl0j" is invalid: spec.network.subnets[1]: Duplicate value: map[string]interface {}{"id":""}

First guess: the breaking change to require subnets[*].resourceID hasn't been applied when bumping to the v1beta2 CRD types.

Designed behavior

Create and delete stuff correctly.

Reproduction Steps

PR comment to only trigger private tests (takes roughly an hour):

/run cluster-test-suites TARGET_SUITES=./providers/capa/private

Technical information

Since the operator doesn't do much on subnets, I'm wondering why the reconciliation code even needs to touch those fields. It's supposed to only patch in route table IDs and stuff, rather than overwrite ID fields. And maybe the whole functionality can be replaced by CAPA tagging the subnets correctly, removing our whole subnets reconciliation code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service kind/bug phoenix-size/s provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix topic/capi
Projects
Archived in project
2 participants