SAM.Game filter not working correctly?

[bbfox0703]

Original Code in Manager.cs

if (textSearch != null)
{
    if (def.Name.IndexOf(textSearch, StringComparison.OrdinalIgnoreCase) < 0 ||
        def.Description.IndexOf(textSearch, StringComparison.OrdinalIgnoreCase) < 0)
    {
        continue;
    }
}

---

Issue

• The current logic skips the entry if either Name or Description does not match the search term.
• This makes it impossible to filter achievements based solely on Description.

---

Proposed Solution

The logic can be updated to:

1. Use && instead of ||.
2. Check if Description is either empty or does not match the search term.

Here’s the revised code:

if (textSearch != null)
{
    if (def.Name.IndexOf(textSearch, StringComparison.OrdinalIgnoreCase) < 0 &&
        (string.IsNullOrEmpty(def.Description) || def.Description.IndexOf(textSearch, StringComparison.OrdinalIgnoreCase) < 0))
    {
        continue;
    }
}

---

Explanation

• The updated condition ensures the entry is skipped only if both conditions fail:
  1. The Name does not contain the search term.
  2. The Description is either empty or does not contain the search term.
• This fix allows filtering by either Name or Description, ensuring the functionality is more flexible.

---

Improved Behavior

• Original Code: If Name does not match, the entry is skipped regardless of whether Description matches or not.
• Revised Code: If Name does not match, the Description is still checked. If it matches, the entry is not skipped.

This ensures that the filtering logic meets the requirement of "matching either condition to include the entry."