Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample attribute "comment" gets removed when updating a sample via admin page #945

Open
only1chunts opened this issue Jan 21, 2022 · 1 comment
Assignees

Comments

@only1chunts
Copy link
Member

Describe the bug
In dataset 100987 a sample needed a typo updated in one of the samples, when this was done in the admin page the comment attribute was removed by the commit action despite the comment having not been deleted by the admin person

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://gigadb.org/adminSample/update/id/148151
  2. Click on 'Save'
  3. See the confirmation of what is saved to the database and notice that the comment attribute is now missing

NB the full list of attributes are
Description="MicroCT image data (volumetric TIFF stack) and surface-rendered 3D reconstructions (STL format) of skull and dentition of Timon lepidus",life_stage="Adult",age="not provided",sample_source="Department of Anatomy, Histology and Embryology at the Faculty of Veterinary Medicine, University of Veterinary Sciences Brno, Czech Republic",tissue_type="Head [UBERON:0000033]",collection_date="not provided",Exp_Scan method="MicroCT",Exp_Scanner="GE Phoenix v|tome|x L 240",Exp_Scan_parameters="Acceleration voltage of the X-ray tube 60 kV; Tube current 230 μA; Exposure time 500 ms; 2600 images",Exp_Scan_resolution="18 µm (isotropic)",comment="Specimens originated from private breeders. Deceased animals were part of the collection of the Department of Anatomy, Histology and Embryology at the Faculty of Veterinary Medicine, University of Veterinary Sciences Brno (Brno, Czech Republic)."

Expected behavior
all listed attributes with values should be added to the database as provided and the confirmation page should show those.
IF for any reason something is NOT added then a message should be presented to the admin user explaining what has been ignored and why.

Screenshots
image

image

Additional context
My GUESS is that there is a char limit on the length of the comment attribute that has been exceeded in this case.

@rija
Copy link
Contributor

rija commented Mar 4, 2022

This is a quick bug fix. The proper fix to the acward workflow will be done in #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants