-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reader::Address
associated type
#409
Comments
Sounds good to me! At the least it would be nice not to force |
Could you please provide an estimate of the efforts required to implement this functionality? |
@vaibspider It's not a beginner task, and will require widespread changes to the read module. Unless someone has better ideas, the process will be:
I'm not sure if there is any way to break that last step into something more manageable. Note that in theory relocatable addresses should already be possible. This issue would just make it nicer. So unless you're keen to do this, I would try to use the existing method. I'm currently updating my |
Thanks for the insight! I tested reading a couple of relocatable object files, regenerating them (using |
Replying in #482. |
This should support the following uses:
I wanted this when doing the relocated address support, but didn't do it because of how ugly the
Reader::Offset
support had been. However, I don't think that's so bad now after the default offset was changed in #392.Any thoughts on this @fitzgen ?
The text was updated successfully, but these errors were encountered: