diff --git a/core/config/config.cpp b/core/config/config.cpp index 160f88ce65c..291c7cab41c 100644 --- a/core/config/config.cpp +++ b/core/config/config.cpp @@ -29,7 +29,7 @@ deferred_factory_parameter parse(const pnode& config, obj.get_string()); return func(config, context, td); } - GKO_MISS_CONFIG_ENTRY("type"); + GKO_MISSING_CONFIG_ENTRY("type"); } diff --git a/core/config/config_helper.hpp b/core/config/config_helper.hpp index f3461289e7a..3a7a426d138 100644 --- a/core/config/config_helper.hpp +++ b/core/config/config_helper.hpp @@ -32,7 +32,7 @@ namespace config { "<")) -#define GKO_MISS_CONFIG_ENTRY(_entry) \ +#define GKO_MISSING_CONFIG_ENTRY(_entry) \ GKO_INVALID_STATE(std::string("The entry >") + _entry + "< is missing") @@ -294,7 +294,7 @@ inline std::shared_ptr get_strategy( } else { GKO_INVALID_CONFIG_VALUE("strategy", str); } - return std::move(strategy_ptr); + return strategy_ptr; } diff --git a/core/config/preconditioner_config.cpp b/core/config/preconditioner_config.cpp index 991e9709ab4..e5f8ee94ea6 100644 --- a/core/config/preconditioner_config.cpp +++ b/core/config/preconditioner_config.cpp @@ -289,7 +289,7 @@ deferred_factory_parameter parse( GKO_INVALID_CONFIG_VALUE("isai_type", str); } } else { - GKO_MISS_CONFIG_ENTRY("isai_type"); + GKO_MISSING_CONFIG_ENTRY("isai_type"); } } diff --git a/core/preconditioner/ic.cpp b/core/preconditioner/ic.cpp index 1748d3cdcdc..c4613d30ea6 100644 --- a/core/preconditioner/ic.cpp +++ b/core/preconditioner/ic.cpp @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include #include diff --git a/core/preconditioner/ilu.cpp b/core/preconditioner/ilu.cpp index 34d41c09cf6..652ade0152c 100644 --- a/core/preconditioner/ilu.cpp +++ b/core/preconditioner/ilu.cpp @@ -10,6 +10,7 @@ #include #include #include +#include #include #include diff --git a/include/ginkgo/core/factorization/cholesky.hpp b/include/ginkgo/core/factorization/cholesky.hpp index e1799766b43..579f10d6e60 100644 --- a/include/ginkgo/core/factorization/cholesky.hpp +++ b/include/ginkgo/core/factorization/cholesky.hpp @@ -77,6 +77,11 @@ class Cholesky */ const parameters_type& get_parameters() { return parameters_; } + /** + * @copydoc get_parameters + */ + const parameters_type& get_parameters() const { return parameters_; } + /** * @copydoc LinOpFactory::generate * @note This function overrides the default LinOpFactory::generate to @@ -90,8 +95,6 @@ class Cholesky /** Creates a new parameter_type to set up the factory. */ static parameters_type build() { return {}; } - const parameters_type& get_parameters() const { return parameters_; } - /** * Create the parameters from the property_tree. * Because this is directly tied to the specific type, the value/index type diff --git a/include/ginkgo/core/factorization/lu.hpp b/include/ginkgo/core/factorization/lu.hpp index 6557d455577..768393b4388 100644 --- a/include/ginkgo/core/factorization/lu.hpp +++ b/include/ginkgo/core/factorization/lu.hpp @@ -107,6 +107,11 @@ class Lu */ const parameters_type& get_parameters() { return parameters_; } + /** + * @copydoc get_parameters + */ + const parameters_type& get_parameters() const { return parameters_; } + /** * @copydoc LinOpFactory::generate * @note This function overrides the default LinOpFactory::generate to @@ -120,8 +125,6 @@ class Lu /** Creates a new parameter_type to set up the factory. */ static parameters_type build() { return {}; } - const parameters_type& get_parameters() const { return parameters_; } - /** * Create the parameters from the property_tree. * Because this is directly tied to the specific type, the value/index type diff --git a/include/ginkgo/core/preconditioner/ic.hpp b/include/ginkgo/core/preconditioner/ic.hpp index 5bbfd2ea600..670814f57c5 100644 --- a/include/ginkgo/core/preconditioner/ic.hpp +++ b/include/ginkgo/core/preconditioner/ic.hpp @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include #include #include @@ -39,10 +39,10 @@ namespace detail { template constexpr bool support_ic_parse = - is_instance_of::value || - is_instance_of::value || - is_instance_of::value || - is_instance_of::value; + is_instantiation_of::value || + is_instantiation_of::value || + is_instantiation_of::value || + is_instantiation_of::value; template < diff --git a/include/ginkgo/core/preconditioner/ilu.hpp b/include/ginkgo/core/preconditioner/ilu.hpp index 92f9f148b7f..b2893855e3c 100644 --- a/include/ginkgo/core/preconditioner/ilu.hpp +++ b/include/ginkgo/core/preconditioner/ilu.hpp @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include #include #include @@ -40,10 +40,10 @@ namespace detail { template constexpr bool support_ilu_parse = std::is_same::value && - (is_instance_of::value || - is_instance_of::value || - is_instance_of::value || - is_instance_of::value); + (is_instantiation_of::value || + is_instantiation_of::value || + is_instantiation_of::value || + is_instantiation_of::value); template @@ -19,14 +19,14 @@ namespace detail { // true_type if ExplicitType is an instantiation of TemplateType. template class TemplateType> -struct is_instance_of : std::false_type {}; +struct is_instantiation_of : std::false_type {}; template