-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes Gitlab CI Interruptible #1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome that his now works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tag version needs to out of interruptible job
.gitlab-ci.yml
Outdated
rules: | ||
- if: $CI_COMMIT_BRANCH != "master" && $CI_COMMIT_BRANCH != "develop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the tagged branch $CI_COMMIT_TAG
can not be interruptible.
We also use the tag for the release although the tagged version should only be pushed once.
also @tcojean needs to adjust the option https://docs.gitlab.com/ee/ci/pipelines/settings.html#auto-cancel-redundant-pipelines to make it work |
I've made some dummy commits to test it, see: https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/pipelines/926404360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor format aspect.
I think the interrupt doesn't work if we force push... That makes it not as helpful with our workflow |
It's sad they do not handle the forced push. if it does not lead another error, it's still helpful partially. |
rebase! |
This PR makes our Gitlab CI interruptible, similar to the setup that we have for github. Only CI that does not run on master/develop branch can be interrupted.