Print pre-commit install non-default output #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
reviewed
Dec 6, 2023
yhmtsai
approved these changes
Dec 7, 2023
MarcelKoch
force-pushed
the
warn-on-legacy-git-hook
branch
from
2418f04
to
99c8c34
Compare
pratikvn
approved these changes
Dec 7, 2023
MarcelKoch
force-pushed
the
warn-on-legacy-git-hook
branch
from
99c8c34
to
f2343ef
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
yhmtsai
approved these changes
Dec 8, 2023
MarcelKoch
force-pushed
the
warn-on-legacy-git-hook
branch
from
63a6f55
to
9efad71
Compare
|
Error: PR already merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a message if
pre-commit installexits with non-default output. The default output should be:Anything else might indicate an issue, for example if already another pre-commit hook exists.
I decided against issuing a warning specific for the pre-commit legacy mode, since I hope that this can be more generic.