Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: transposed triangular solver uses the same algorithm as the original one #1641

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Jul 4, 2024

This PR changes the algorithm from transposed triangular solver from the default option to the source.
first commit adds the test which shows failure and then second commit changes the algorithm.

@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Jul 4, 2024
@yhmtsai yhmtsai requested a review from a team July 4, 2024 09:33
@yhmtsai yhmtsai self-assigned this Jul 4, 2024
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. mod:core This is related to the core module. mod:reference This is related to the reference module. type:solver This is related to the solvers labels Jul 4, 2024
@yhmtsai yhmtsai added the is:bugfix This fixes a bug label Jul 4, 2024
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 4, 2024
Copy link

sonarcloud bot commented Jul 6, 2024

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (6c0da56) to head (b9a8c6a).
Report is 31 commits behind head on develop.

Files Patch % Lines
reference/test/solver/lower_trs_kernels.cpp 95.45% 1 Missing ⚠️
reference/test/solver/upper_trs_kernels.cpp 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1641      +/-   ##
===========================================
+ Coverage    90.01%   91.60%   +1.58%     
===========================================
  Files          759      761       +2     
  Lines        61173    61181       +8     
===========================================
+ Hits         55067    56045     +978     
+ Misses        6106     5136     -970     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhmtsai yhmtsai merged commit 70db4f7 into develop Jul 6, 2024
17 checks passed
@yhmtsai yhmtsai deleted the trs_keep_alg branch July 6, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. is:bugfix This fixes a bug mod:core This is related to the core module. mod:reference This is related to the reference module. reg:testing This is related to testing. type:solver This is related to the solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants