feat(user): basculer l'authentification vers Mon Compte Pro #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
3 times, most recently
from
e8f1f04
to
f71c504
Compare
tonial
reviewed
Aug 5, 2024
There was a problem hiding this comment.
J'ai l'impression que tu n'as pas mis à jour le template du bouton de connexion.
Sinon, ça m'a l'air bien (il faudrait peut être faire une recherche d'inclusion.*connect dans le repo de code pour vérifier qu'il n'en reste pas quelque part comme le commentaire repéré.
Est-ce que tu as moyen de désactiver temporairement la connexion (le temps de mettre à jour les subs le jour J) ?
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
from
f71c504
to
850e0f9
Compare
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
from
9ddadb1
to
5133aa3
Compare
vincentporte
added
recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
Echec en code erreur |
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
|
|
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
2 times, most recently
from
95e4fd3
to
feae787
Compare
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
2 times, most recently
from
d5f52f1
to
3ff4525
Compare
vincentporte
force-pushed
the
729-user-bascule-ic-proc
branch
from
8da1b8f
to
985ebfe
Compare
tonial
approved these changes
Sep 2, 2024
| @@ -18,9 +18,9 @@ SIB_API_KEY=__key_to_be_set__ | |||
| #SENTRY_DSN=__url_to_be_set__ | |||
|
|
|||
| # for Inclusion Connect | |||
There was a problem hiding this comment.
le commentaire dit toujours Inclusion Connect
| @@ -26,7 +26,7 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| # Inclusion Connect URLs. | |||
| @@ -26,7 +26,7 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| # Inclusion Connect URLs. | |||
| path("inclusion_connect/", include(inclusion_connect_urls)), | |||
| path("", include(openid_connect_urls)), | |||
There was a problem hiding this comment.
Pourquoi avoir mis le pro_connect dans les urls individuelles ?
vincentporte
added a commit
that referenced
this pull request
Sep 25, 2024
## Description 🎸 Ajout d'un `middleware` pour activer une page parking lors des maintenances techniques à venir : migration IC #731 , et migration de la documentation #765 ## Type de changement 🚧 technique ### Points d'attention 🦺 Ajout de la variable d'environnement `PARKING_PAGE` 🦺 `ParkingPageMiddleware` attrape toutes les requêtes sauf celles vers l'admin lorsqu'il est actif. 🦺 exclure le template `parking.html` du contrôle de `djlint` dans la CI (`make quality`) ### Captures d'écran (optionnel) page parking 
vincentporte
added a commit
that referenced
this pull request
Sep 25, 2024
## Description 🎸 Ajout d'un `middleware` pour activer une page parking lors des maintenances techniques à venir : migration IC #731 , et migration de la documentation #765 ## Type de changement 🚧 technique ### Points d'attention 🦺 Ajout de la variable d'environnement `PARKING_PAGE` 🦺 `ParkingPageMiddleware` attrape toutes les requêtes sauf celles vers l'admin lorsqu'il est actif. 🦺 exclure le template `parking.html` du contrôle de `djlint` dans la CI (`make quality`) ### Captures d'écran (optionnel) page parking 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Inclusion Connect est remplacé par Mon Compte Pro (https://moncomptepro.beta.gouv.fr/)
Type de changement
🚧 technique
Points d'attention
🦺 renommage de l'app django
🦺 mise à jour des urls
🦺 ajout du paramètre
"acr_values": "eidas1"lors de l'appel au end-pointauthorize🦺 remplacement de
family_nameparusual_namelors de l'appel au end-pointuser-info🦺 decoder
user_dataà l'aide de la libPyJWT